pkg/dev_compiler/tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart - Issue 2871363002: Fix more errors in DDC SDK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart

Issue 2871363002: Fix more errors in DDC SDK. (Closed)

Patch Set: Merge branch 'master' into ddc-sdk-errors Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart ('k') | pkg/dev_compiler/tool/input_sdk/private/isolate_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart b/pkg/dev_compiler/tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart

index a58745977906f0b2d83d7d7ccfae453f7860f0fd..bb3123210a2b5c638190d5c8d60acda755790add 100644

--- a/pkg/dev_compiler/tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart

+++ b/pkg/dev_compiler/tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart

@@ -109,7 +109,7 @@ callConstructor(Function constr, List arguments) {

// the arguments list passed to apply().

// After that, use the JavaScript 'new' operator which overrides any binding

// of 'this' with the new instance.

- var args = [null]..addAll(arguments);

+ var args = <dynamic>[null]..addAll(arguments);

var factoryFunction = JS('', '#.bind.apply(#, #)', constr, constr, args);

// Without this line, calling factoryFunction as a constructor throws

JS('String', 'String(#)', factoryFunction);