Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart

Issue 2871363002: Fix more errors in DDC SDK. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart b/pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
index 9e4133148615846b282ece787f044e4658443e8f..a4f28fe77d1cd81a3f85940ed058ac8eba81a879 100644
--- a/pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
+++ b/pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
@@ -204,7 +204,7 @@ class JsObject {
*
* The type of [property] must be either [String] or [num].
*/
- operator []=(Object property, value) {
+ void operator []=(Object property, value) {
if (property is! String && property is! num) {
throw new ArgumentError("property is not a String or num");
}
@@ -367,7 +367,7 @@ class JsArray<E> extends JsObject with ListMixin<E> {
return super[index] as E;
}
- void operator []=(Object index, E value) {
+ void operator []=(Object index, value) {
Bob Nystrom 2017/05/10 22:53:59 Removing "E" here means that the argument is no lo
// TODO(justinfagnani): fix the semantics for non-ints
// dartbug.com/14605
if (index is num && index == index.toInt()) {
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | pkg/dev_compiler/tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698