[webcrypto] Add JWK import/export of RSA private keys (NSS).

content/child/webcrypto/shared_crypto.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_WEBCRYPTO_SHARED_CRYPTO_H_
 #define CONTENT_CHILD_WEBCRYPTO_SHARED_CRYPTO_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 142 matching lines @@
 
 // Called on the target Blink thread.
 CONTENT_EXPORT bool DeserializeKeyForClone(
     const blink::WebCryptoKeyAlgorithm& algorithm,
     blink::WebCryptoKeyType type,
     bool extractable,
     blink::WebCryptoKeyUsageMask usage_mask,
     const CryptoData& key_data,
     blink::WebCryptoKey* key);
 
+namespace platform {
+class SymKey;
+class PublicKey;
+class PrivateKey;
+}
+
+Status ToPlatformSymKey(const blink::WebCryptoKey& key, platform::SymKey** out);
+
+Status ToPlatformPublicKey(const blink::WebCryptoKey& key,
+                           platform::PublicKey** out);
+
+Status ToPlatformPrivateKey(const blink::WebCryptoKey& key,
+                            platform::PrivateKey** out);

[Ryan Sleevi, 2014/05/19 00:10:34]

Feels like a layering violation. I'm not sure why you introduced these?

[eroman, 2014/05/19 18:51:09]

I exposed these for re-use in jwk.cc.

jwk.cc was already using ToPlatformPublicKey() via duplication. This CL now
required ToPlatformPrivateKey() as well. Rather than duplicate that as well, I
decided to expose them.

I agree shared_crypto.h is not the best place for these, however the other files
are also unsuited.

platform_crypto.h would be a reasonable place to expose the declaration, however
the issue is where to put the definition (there is no platform_crypto.cc, only
platform_crypto_nss.cc and platform_crypto_openssl.cc).

Suggestions? I could declare in platform_crypto.h and then define in
shared_crypto.cc but that feels strange too.

+
 }  // namespace webcrypto
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_WEBCRYPTO_SHARED_CRYPTO_H_