Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4152)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 2871323002: Fix flaky LayerTreeHostTestStartPageScaleAnimation test. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 6e428798b878b8715e9d463534c0f109db5d52f2..04dcd0a547038d0aa14a355ac3326349256bb54c 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -2472,15 +2472,16 @@ class LayerTreeHostTestStartPageScaleAnimation : public LayerTreeHostTest {
break;
case 1:
EXPECT_EQ(1.f, impl->active_tree()->current_page_scale_factor());
+ // Once the animation starts, an ImplFrame will be requested. However,
+ // main frames may be happening in the mean-time due to high-latency
+ // mode. If one happens before the next impl frame, then the source
+ // frame number may increment twice instead of just once.
break;
case 2:
+ case 3:
EXPECT_EQ(1.25f, impl->active_tree()->current_page_scale_factor());
EndTest();
break;
- case 3:
- break;
- default:
- NOTREACHED();
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698