[WebModals] New API for browser-scoped popup management.

chrome/browser/ui/browser.h

Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index beb3dddd95fead3fb82cef1c065537b2e9e8b2f6..bb46d93865d787425564fa68920ecaae015e300a 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -91,6 +91,7 @@ class WebDialogDelegate;
 }
 
 namespace web_modal {
+class PopupManager;
 class WebContentsModalDialogHost;
 }
 
@@ -242,6 +243,7 @@ class Browser : public TabStripModelObserver,
     toolbar_model->swap(toolbar_model_);
   }
 #endif
+  web_modal::PopupManager* popup_manager() const { return popup_manager_.get(); }
   TabStripModel* tab_strip_model() const { return tab_strip_model_.get(); }
   chrome::BrowserCommandController* command_controller() {
     return command_controller_.get();
@@ -818,6 +820,10 @@ class Browser : public TabStripModelObserver,
   // This Browser's window.
   BrowserWindow* window_;
 
+  // Manages popup windows (bubbles, tab-modals) visible overlapping this
+  // window.
+  scoped_ptr<web_modal::PopupManager> popup_manager_;

[msw, 2014/05/22 04:08:45]

Why should this be a scoped_ptr rather than a non-pointer class member?

[Greg Billock, 2014/05/22 18:25:47]

No particular reason right now -- in general scoped_ptr members are easier to
inject test instances into and such, but that's probably not a concern here.

+
   scoped_ptr<TabStripModelDelegate> tab_strip_model_delegate_;
   scoped_ptr<TabStripModel> tab_strip_model_;