chrome/browser/chromeos/login/ui/webui_login_view.cc - Issue 287123002: [WebModals] New API for browser-scoped popup management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.cc

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cocoa, more test fiddles, etc Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/ui/webui_login_view.cc

diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.cc b/chrome/browser/chromeos/login/ui/webui_login_view.cc

index cdadcf225f7a530e33cee2b76bdc792289c5616d..4efb3cb0a8934244f2b6d82dbd4f3ef4dd3a1580 100644

--- a/chrome/browser/chromeos/login/ui/webui_login_view.cc

+++ b/chrome/browser/chromeos/login/ui/webui_login_view.cc

@@ -186,6 +186,9 @@ void WebUILoginView::Init() {

WebContentsModalDialogManager::CreateForWebContents(web_contents);

WebContentsModalDialogManager::FromWebContents(web_contents)->

SetDelegate(this);

+ if (!popup_manager_.get())

+ popup_manager_.reset(new web_modal::PopupManager(this));

+ popup_manager_->RegisterWith(web_contents);

web_contents->SetDelegate(this);

extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(