chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm - Issue 287123002: [WebModals] New API for browser-scoped popup management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More test fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

index 7e6031b1c5d93e04d81ec73d54470025f30e0bb3..36da7ec7cc7d71d58eba62da339ca926ed50a88f 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

@@ -33,6 +33,7 @@ ConstrainedWindowMac::ConstrainedWindowMac(

web_contents_ = web_view_guest && web_view_guest->embedder_web_contents() ?

web_view_guest->embedder_web_contents() : web_contents;

DCHECK(sheet_.get());

+ // TODO(gbillock): Use PopupManager here.

Mike Wittman 2014/06/25 02:38:50 Do you intend to address the Mac usage in this CL?

Greg Billock 2014/06/25 19:06:14 Done.

WebContentsModalDialogManager* web_contents_modal_dialog_manager =

WebContentsModalDialogManager::FromWebContents(web_contents_);

web_contents_modal_dialog_manager->ShowModalDialog(this);