[WebModals] New API for browser-scoped popup management.

components/web_modal/native_web_contents_modal_dialog.h

Index: components/web_modal/native_web_contents_modal_dialog.h
diff --git a/components/web_modal/native_web_contents_modal_dialog.h b/components/web_modal/native_web_contents_modal_dialog.h
index 266e073ab9c0bfd6dcb57cdfce9071dd579458ac..4bb956a8ef09010a78bb25d41b177dfa53f72c86 100644
--- a/components/web_modal/native_web_contents_modal_dialog.h
+++ b/components/web_modal/native_web_contents_modal_dialog.h
@@ -9,6 +9,8 @@
 
 namespace web_modal {
 
+// TODO(gbillock): rename this file
+
 #if defined(OS_MACOSX)
 // Use a void* since none of the gfx::Native* types are suitable for
 // representing the web contents modal dialog under Cocoa.
@@ -17,6 +19,14 @@ typedef void* NativeWebContentsModalDialog;
 typedef gfx::NativeView NativeWebContentsModalDialog;
 #endif
 
+#if defined(OS_MACOSX)
+// Use a void* since none of the gfx::Native* types are suitable for

[msw, 2014/05/16 17:10:57]

Interesting, NSWindow (gfx::NativeWindow) and NSView (gfx::NativeView) aren't
applicable for neither bubbles nor dialogs?

[Mike Wittman, 2014/05/16 20:35:40]

See https://codereview.chromium.org/12224020 for the extended discussion on why
neither gfx::NativeWindow nor gfx::NativeView work for WCMDs. Similar logic may
or may not also apply to popups.

+// representing a popup window under Cocoa.
+typedef void* NativePopup;
+#else
+typedef gfx::NativeView NativePopup;
+#endif

[Finnur, 2014/05/16 12:38:14]

I probably would merge these two #if defs.

Out of curiosity... Anyone know the reason why we didn't append Ptr to these
names (as in NativeViewPtr and NativePopupPtr)? :)

[msw, 2014/05/16 17:10:57]

NativeWindow was at one point HWND, which is a handle, not a really a pointer.

+
 }  // namespace web_modal
 
 #endif  // COMPONENTS_WEB_MODAL_NATIVE_WEB_CONTENTS_MODAL_DIALOG_H_