components/web_modal/web_contents_modal_dialog_manager.h - Issue 287123002: [WebModals] New API for browser-scoped popup management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make PopupManager a thin API for WCMDM Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/web_modal/web_contents_modal_dialog_manager.h

diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h

index 753130158cbab471866ba2e738b5a6abd0ee71f6..3f9bf34d4dd9ced98524e2a32ac151bad08fedb3 100644

--- a/components/web_modal/web_contents_modal_dialog_manager.h

+++ b/components/web_modal/web_contents_modal_dialog_manager.h

@@ -47,11 +47,10 @@ class WebContentsModalDialogManager

// Focus the topmost modal dialog. IsDialogActive() must be true when calling

// this function.

- void FocusTopmostDialog();

+ void FocusTopmostDialog() const;

- // Overriden from SingleWebContentsDialogManagerDelegate:

+ // SingleWebContentsDialogManagerDelegate:

virtual content::WebContents* GetWebContents() const OVERRIDE;

- // Called when a WebContentsModalDialogs we own is about to be closed.

virtual void WillClose(NativeWebContentsModalDialog dialog) OVERRIDE;

// For testing.