chrome/browser/ui/views/login_prompt_views.cc - Issue 287123002: [WebModals] New API for browser-scoped popup management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/login_prompt_views.cc

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make PopupManager a thin API for WCMDM Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/login_prompt_views.cc

diff --git a/chrome/browser/ui/views/login_prompt_views.cc b/chrome/browser/ui/views/login_prompt_views.cc

index 5ea8defa4eacc36d951cb832e5bc21f2497273b3..96e61dd0e7eb4e0934f3afee45383106c82f5237 100644

--- a/chrome/browser/ui/views/login_prompt_views.cc

+++ b/chrome/browser/ui/views/login_prompt_views.cc

@@ -142,6 +142,7 @@ class LoginHandlerViews : public LoginHandler,

// control). However, that's OK since any UI interaction in those functions

// will occur via an InvokeLater on the UI thread, which is guaranteed

// to happen after this is called (since this was InvokeLater'd first).

+ // TODO(gbillock): Use PopupManager here.

WebContents* requesting_contents = GetWebContentsForLogin();

WebContentsModalDialogManager* web_contents_modal_dialog_manager =

WebContentsModalDialogManager::FromWebContents(requesting_contents);