chrome/browser/chromeos/attestation/platform_verification_dialog.cc - Issue 287123002: [WebModals] New API for browser-scoped popup management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/attestation/platform_verification_dialog.cc

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make PopupManager a thin API for WCMDM Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/attestation/platform_verification_dialog.cc

diff --git a/chrome/browser/chromeos/attestation/platform_verification_dialog.cc b/chrome/browser/chromeos/attestation/platform_verification_dialog.cc

index 2bda3a83d38a697ace8c39173c745b720cc0a365..8380041646305a17d6b3453c1aaae28ce67e22cc 100644

--- a/chrome/browser/chromeos/attestation/platform_verification_dialog.cc

+++ b/chrome/browser/chromeos/attestation/platform_verification_dialog.cc

@@ -54,6 +54,7 @@ void PlatformVerificationDialog::ShowDialog(

callback);

// Sets up the dialog widget and shows it.

+ // TODO(gbillock): Use PopupManager here.

web_modal::WebContentsModalDialogManager* web_contents_modal_dialog_manager =

web_modal::WebContentsModalDialogManager::FromWebContents(web_contents);

web_modal::WebContentsModalDialogManagerDelegate* modal_delegate =

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc » ('j') | components/web_modal/popup_manager.h » ('J')