[WebModals] New API for browser-scoped popup management.

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 226 matching lines @@
   else
     new_tab->GetController().Reload(true);
 }
 
 bool IsShowingWebContentsModalDialog(const Browser* browser) {
   WebContents* web_contents =
       browser->tab_strip_model()->GetActiveWebContents();
   if (!web_contents)
     return false;
 
+  // TODO(gbillock): This caller needs update to the PopupManager. It gets
+  // called by the CanPrint method, which may be too restrictive if we allow
+  // print preview to overlap -- we should just queue print requests or attach
+  // a user gesture or whatever we know.
+
   WebContentsModalDialogManager* web_contents_modal_dialog_manager =
       WebContentsModalDialogManager::FromWebContents(web_contents);
   return web_contents_modal_dialog_manager->IsDialogActive();
 }
 
 bool PrintPreviewShowing(const Browser* browser) {
 #if defined(ENABLE_FULL_PRINTING)
   WebContents* contents = browser->tab_strip_model()->GetActiveWebContents();
   printing::PrintPreviewDialogController* controller =
       printing::PrintPreviewDialogController::GetInstance();
@@ skipping 471 matching lines @@
 
       case extensions::CommandService::BROWSER_ACTION:
         // BookmarkCurrentPage is called through a user gesture, so it is safe
         // to call ShowBrowserActionPopup.
         browser->window()->ShowBrowserActionPopup(extension);
         return;
 
       case extensions::CommandService::PAGE_ACTION:
         browser->window()->ShowPageActionPopup(extension);
         return;
-    };
+    }
   }
 
   BookmarkCurrentPageInternal(browser);
 }
 
 bool CanBookmarkCurrentPage(const Browser* browser) {
   return CanBookmarkCurrentPageInternal(browser, true);
 }
 
 void BookmarkAllTabs(Browser* browser) {
@@ skipping 508 matching lines @@
                                           browser->profile(),
                                           browser->host_desktop_type()));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 
 }  // namespace chrome