Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: chrome/browser/ui/views/constrained_window_views.cc

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/constrained_window_views.h" 5 #include "chrome/browser/ui/views/constrained_window_views.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "chrome/browser/guest_view/web_view/web_view_guest.h" 9 #include "chrome/browser/guest_view/web_view/web_view_guest.h"
10 #include "chrome/browser/ui/browser_finder.h" 10 #include "chrome/browser/ui/browser_finder.h"
11 #include "components/web_modal/popup_manager.h"
11 #include "components/web_modal/web_contents_modal_dialog_host.h" 12 #include "components/web_modal/web_contents_modal_dialog_host.h"
12 #include "components/web_modal/web_contents_modal_dialog_manager.h"
13 #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
14 #include "ui/views/border.h" 13 #include "ui/views/border.h"
15 #include "ui/views/widget/widget.h" 14 #include "ui/views/widget/widget.h"
16 #include "ui/views/widget/widget_observer.h" 15 #include "ui/views/widget/widget_observer.h"
17 #include "ui/views/window/dialog_delegate.h" 16 #include "ui/views/window/dialog_delegate.h"
18 17
19 using web_modal::ModalDialogHost; 18 using web_modal::ModalDialogHost;
20 using web_modal::ModalDialogHostObserver; 19 using web_modal::ModalDialogHostObserver;
21 20
22 namespace { 21 namespace {
23 // The name of a key to store on the window handle to associate 22 // The name of a key to store on the window handle to associate
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 views::WidgetDelegate* dialog, 124 views::WidgetDelegate* dialog,
126 content::WebContents* initiator_web_contents) { 125 content::WebContents* initiator_web_contents) {
127 WebViewGuest* web_view_guest = WebViewGuest::FromWebContents( 126 WebViewGuest* web_view_guest = WebViewGuest::FromWebContents(
128 initiator_web_contents); 127 initiator_web_contents);
129 // For embedded WebContents, use the embedder's WebContents for constrained 128 // For embedded WebContents, use the embedder's WebContents for constrained
130 // window. 129 // window.
131 content::WebContents* web_contents = 130 content::WebContents* web_contents =
132 web_view_guest && web_view_guest->embedder_web_contents() ? 131 web_view_guest && web_view_guest->embedder_web_contents() ?
133 web_view_guest->embedder_web_contents() : initiator_web_contents; 132 web_view_guest->embedder_web_contents() : initiator_web_contents;
134 views::Widget* widget = CreateWebModalDialogViews(dialog, web_contents); 133 views::Widget* widget = CreateWebModalDialogViews(dialog, web_contents);
135 web_modal::WebContentsModalDialogManager::FromWebContents(web_contents)-> 134 web_modal::PopupManager* popup_manager =
136 ShowModalDialog(widget->GetNativeWindow()); 135 web_modal::PopupManager::FromWebContents(web_contents);
136 popup_manager->ShowModalDialog(widget->GetNativeWindow(), web_contents);
137 return widget; 137 return widget;
138 } 138 }
139 139
140 views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog, 140 views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog,
141 content::WebContents* web_contents) { 141 content::WebContents* web_contents) {
142 DCHECK_EQ(ui::MODAL_TYPE_CHILD, dialog->GetModalType()); 142 DCHECK_EQ(ui::MODAL_TYPE_CHILD, dialog->GetModalType());
143 web_modal::WebContentsModalDialogManager* manager = 143 web_modal::PopupManager* popup_manager =
144 web_modal::WebContentsModalDialogManager::FromWebContents(web_contents); 144 web_modal::PopupManager::FromWebContents(web_contents);
145 const gfx::NativeWindow parent = 145 const gfx::NativeWindow parent = popup_manager->GetHostView();
146 manager->delegate()->GetWebContentsModalDialogHost()->GetHostView();
147 return views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent); 146 return views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent);
148 } 147 }
149 148
149 // TODO(gbillock): Replace this with PopupManager calls.
150 views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog, 150 views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,
151 gfx::NativeWindow parent) { 151 gfx::NativeWindow parent) {
152 views::Widget* widget = 152 views::Widget* widget =
153 views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent); 153 views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent);
154 if (!dialog->UseNewStyleForThisDialog()) 154 if (!dialog->UseNewStyleForThisDialog())
155 return widget; 155 return widget;
156 156
157 // Get the browser dialog management and hosting components from |parent|. 157 // Get the browser dialog management and hosting components from |parent|.
158 Browser* browser = chrome::FindBrowserWithWindow(parent); 158 Browser* browser = chrome::FindBrowserWithWindow(parent);
159 if (browser) { 159 if (browser) {
160 ChromeWebModalDialogManagerDelegate* manager = browser; 160 ChromeWebModalDialogManagerDelegate* manager = browser;
161 ModalDialogHost* host = manager->GetWebContentsModalDialogHost(); 161 ModalDialogHost* host = manager->GetWebContentsModalDialogHost();
162 DCHECK_EQ(parent, host->GetHostView()); 162 DCHECK_EQ(parent, host->GetHostView());
163 ModalDialogHostObserver* dialog_host_observer = 163 ModalDialogHostObserver* dialog_host_observer =
164 new BrowserModalDialogHostObserverViews( 164 new BrowserModalDialogHostObserverViews(
165 host, widget, kBrowserModalDialogHostObserverViewsKey); 165 host, widget, kBrowserModalDialogHostObserverViewsKey);
166 dialog_host_observer->OnPositionRequiresUpdate(); 166 dialog_host_observer->OnPositionRequiresUpdate();
167 } 167 }
168 return widget; 168 return widget;
169 } 169 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/tabs/tab_strip_model_unittest.cc ('k') | chrome/browser/ui/views/desktop_media_picker_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698