[WebModals] New API for browser-scoped popup management.

chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
 
 #include <algorithm>
 
 #include "base/callback.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/extensions/extension_view_host.h"
 #include "chrome/browser/extensions/extension_view_host_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
 #import "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_view_mac.h"
 #import "chrome/browser/ui/cocoa/info_bubble_window.h"
-#include "components/web_modal/web_contents_modal_dialog_manager.h"
+#include "components/web_modal/popup_manager.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/devtools_manager.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_source.h"
 #include "ui/base/cocoa/window_size_constants.h"
 
 using content::BrowserContext;
 using content::RenderViewHost;
 
@@ skipping 170 matching lines @@
   [super dealloc];
 }
 
 - (void)showDevTools {
   DevToolsWindow::OpenDevToolsWindow(host_->render_view_host());
 }
 
 - (void)close {
   // |windowWillClose:| could have already been called. http://crbug.com/279505
   if (host_) {
-    web_modal::WebContentsModalDialogManager* modalDialogManager =
-        web_modal::WebContentsModalDialogManager::FromWebContents(
-            host_->host_contents());
-    if (modalDialogManager &&
-        modalDialogManager->IsDialogActive()) {
+    // TODO(gbillock): Change this API to say directly if the current popup
+    // should block tab close? This is a bit over-reaching.
+    Browser* browser =
+        chrome::FindBrowserWithWebContents(host_->host_contents());
+    if (browser && browser->popup_manager()->IsWebModalDialogActive(

[Mike Wittman, 2014/06/25 21:12:44]

Can we use PopupManager::FromWebContents() here as well?

[Greg Billock, 2014/06/26 00:21:12]

Done.

+            host_->host_contents())) {
       return;
     }
     // We must shutdown host_ immediately, and it will notify RendererProcess
     // right away. We can't wait to do it in
     // -[ExtensionPopController windowWillClose:...]
     if (host_->view())
       host_->view()->set_container(NULL);
     host_.reset();
   }
   [super close];
 }
 
 - (void)windowWillClose:(NSNotification*)notification {
   [super windowWillClose:notification];
   if (gPopup == self)
     gPopup = nil;
 }
 
 - (void)windowDidResignKey:(NSNotification*)notification {
   // |windowWillClose:| could have already been called. http://crbug.com/279505
   if (host_) {
     // When a modal dialog is opened on top of the popup and when it's closed,
     // it steals key-ness from the popup. Don't close the popup when this
     // happens. There's an extra windowDidResignKey: notification after the
     // modal dialog closes that should also be ignored.
-    web_modal::WebContentsModalDialogManager* modalDialogManager =
-        web_modal::WebContentsModalDialogManager::FromWebContents(
+    web_modal::PopupManager* popupManager =
+        web_modal::PopupManager::FromWebContents(
             host_->host_contents());
-    if (modalDialogManager &&
-        modalDialogManager->IsDialogActive()) {
+    if (popupManager &&
+        popupManager->IsWebModalDialogActive(host_->host_contents())) {
       ignoreWindowDidResignKey_ = YES;
       return;
     }
     if (ignoreWindowDidResignKey_) {
       ignoreWindowDidResignKey_ = NO;
       return;
     }
   }
   if (!beingInspected_)
     [super windowDidResignKey:notification];
@@ skipping 158 matching lines @@
   return minSize;
 }
 
 // Private (TestingAPI)
 + (NSSize)maxPopupSize {
   NSSize maxSize = {ExtensionViewMac::kMaxWidth, ExtensionViewMac::kMaxHeight};
   return maxSize;
 }
 
 @end