Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Side by Side Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make PopupManager a thin API for WCMDM Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h" 5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 1225 matching lines...) Expand 10 before | Expand all | Expand 10 after
1236 } 1236 }
1237 1237
1238 void AutofillDialogViews::Show() { 1238 void AutofillDialogViews::Show() {
1239 InitChildViews(); 1239 InitChildViews();
1240 UpdateAccountChooser(); 1240 UpdateAccountChooser();
1241 UpdateNotificationArea(); 1241 UpdateNotificationArea();
1242 UpdateButtonStripExtraView(); 1242 UpdateButtonStripExtraView();
1243 1243
1244 // Ownership of |contents_| is handed off by this call. The widget will take 1244 // Ownership of |contents_| is handed off by this call. The widget will take
1245 // care of deleting itself after calling DeleteDelegate(). 1245 // care of deleting itself after calling DeleteDelegate().
1246 // TODO(gbillock): Use PopupManager here. Also, this comment looks stale.
1246 WebContentsModalDialogManager* web_contents_modal_dialog_manager = 1247 WebContentsModalDialogManager* web_contents_modal_dialog_manager =
1247 WebContentsModalDialogManager::FromWebContents( 1248 WebContentsModalDialogManager::FromWebContents(
1248 delegate_->GetWebContents()); 1249 delegate_->GetWebContents());
1249 WebContentsModalDialogManagerDelegate* modal_delegate = 1250 WebContentsModalDialogManagerDelegate* modal_delegate =
1250 web_contents_modal_dialog_manager->delegate(); 1251 web_contents_modal_dialog_manager->delegate();
1251 DCHECK(modal_delegate); 1252 DCHECK(modal_delegate);
1252 window_ = views::Widget::CreateWindowAsFramelessChild( 1253 window_ = views::Widget::CreateWindowAsFramelessChild(
1253 this, modal_delegate->GetWebContentsModalDialogHost()->GetHostView()); 1254 this, modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
1254 web_contents_modal_dialog_manager->ShowModalDialog( 1255 web_contents_modal_dialog_manager->ShowModalDialog(
1255 window_->GetNativeView()); 1256 window_->GetNativeView());
(...skipping 1256 matching lines...) Expand 10 before | Expand all | Expand 10 after
2512 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section) 2513 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
2513 : section(section), 2514 : section(section),
2514 container(NULL), 2515 container(NULL),
2515 manual_input(NULL), 2516 manual_input(NULL),
2516 suggested_info(NULL), 2517 suggested_info(NULL),
2517 suggested_button(NULL) {} 2518 suggested_button(NULL) {}
2518 2519
2519 AutofillDialogViews::DetailsGroup::~DetailsGroup() {} 2520 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
2520 2521
2521 } // namespace autofill 2522 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698