[WebModals] New API for browser-scoped popup management.

chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
 
 #include <algorithm>
 
 #include "base/callback.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 189 matching lines @@
   [super dealloc];
 }
 
 - (void)showDevTools {
   DevToolsWindow::OpenDevToolsWindow(host_->render_view_host());
 }
 
 - (void)close {
   // |windowWillClose:| could have already been called. http://crbug.com/279505
   if (host_) {
-    web_modal::WebContentsModalDialogManager* modalDialogManager =
-        web_modal::WebContentsModalDialogManager::FromWebContents(
-            host_->host_contents());
-    if (modalDialogManager &&
-        modalDialogManager->IsDialogActive()) {
+    // TODO(gbillock): Change this API to say directly if the current popup
+    // should block tab close? This is a bit over-reaching.
+    Browser* browser = chrome::BrowserFromWebContents(host_->host_contents());
+    if (browser && browser->popup_manager()->IsWebModalDialogActive(
+            host_->host_contents())) {
       return;
     }
   }
   [super close];
 }
 
 - (void)windowWillClose:(NSNotification *)notification {
   [super windowWillClose:notification];
   if (gPopup == self)
     gPopup = nil;
   if (host_->view())
     host_->view()->set_container(NULL);
   host_.reset();
 }
 
 - (void)windowDidResignKey:(NSNotification*)notification {
   // |windowWillClose:| could have already been called. http://crbug.com/279505
   if (host_) {
     // When a modal dialog is opened on top of the popup and when it's closed,
     // it steals key-ness from the popup. Don't close the popup when this
     // happens. There's an extra windowDidResignKey: notification after the
     // modal dialog closes that should also be ignored.
+    // TODO(gbillock): Repoint to the PopupManager. Is this even an issue this
+    // class needs to worry about? Or can we eliminate this case through the
+    // PopupManager itself?
     web_modal::WebContentsModalDialogManager* modalDialogManager =
         web_modal::WebContentsModalDialogManager::FromWebContents(
             host_->host_contents());
     if (modalDialogManager &&
         modalDialogManager->IsDialogActive()) {
       ignoreWindowDidResignKey_ = YES;
       return;
     }
     if (ignoreWindowDidResignKey_) {
       ignoreWindowDidResignKey_ = NO;
@@ skipping 158 matching lines @@
   return minSize;
 }
 
 // Private (TestingAPI)
 + (NSSize)maxPopupSize {
   NSSize maxSize = {ExtensionViewMac::kMaxWidth, ExtensionViewMac::kMaxHeight};
   return maxSize;
 }
 
 @end