Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl_unittest.cc

Issue 2871223002: memory-infra: add ProcessType and expose data in RequestGlobalDump() (Closed)
Patch Set: review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl_unittest.cc
diff --git a/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl_unittest.cc b/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl_unittest.cc
index c5168a897caa8a2882e2f9f9b52c67b9af55cc48..1d8aa11beead7fae625cdbad747138b3f65c2637 100644
--- a/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl_unittest.cc
+++ b/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl_unittest.cc
@@ -36,7 +36,7 @@ class MockCoordinator : public Coordinator, public mojom::Coordinator {
void RequestGlobalMemoryDump(
const base::trace_event::MemoryDumpRequestArgs& args,
const RequestGlobalMemoryDumpCallback& callback) override {
- callback.Run(args.dump_guid, true);
+ callback.Run(args.dump_guid, true, mojom::GlobalMemoryDumpPtr());
}
private:
@@ -50,7 +50,9 @@ class ProcessLocalDumpManagerImplTest : public testing::Test {
coordinator_.reset(new MockCoordinator());
mdm_.reset(new MemoryDumpManager());
MemoryDumpManager::SetInstanceForTesting(mdm_.get());
- ProcessLocalDumpManagerImpl::Config config(coordinator_.get());
+ auto process_type = mojom::ProcessType::OTHER;
+ ProcessLocalDumpManagerImpl::Config config(coordinator_.get(),
+ process_type);
local_manager_impl_.reset(new ProcessLocalDumpManagerImpl(config));
local_manager_impl_->SetAsNonCoordinatorForTesting();

Powered by Google App Engine
This is Rietveld 408576698