Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc

Issue 2871223002: memory-infra: add ProcessType and expose data in RequestGlobalDump() (Closed)
Patch Set: review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
index 521f8f205cfa7768812575e1d449ab209dca0660..f743a2b273d0224e5c1b3651fed229ce9f8909e1 100644
--- a/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
@@ -47,7 +47,8 @@ class CoordinatorImplTest : public testing::Test {
void OnGlobalMemoryDumpResponse(base::Closure closure,
uint64_t dump_guid,
- bool success) {
+ bool success,
+ mojom::GlobalMemoryDumpPtr) {
dump_response_args_ = {dump_guid, success};
closure.Run();
}
@@ -82,8 +83,7 @@ class MockDumpManager : public mojom::ProcessLocalDumpManager {
const base::trace_event::MemoryDumpRequestArgs& args,
const RequestProcessMemoryDumpCallback& callback) override {
expected_calls_--;
- base::trace_event::MemoryDumpCallbackResult result;
- callback.Run(args.dump_guid, true, result);
+ callback.Run(args.dump_guid, true, mojom::ProcessMemoryDumpPtr());
}
private:

Powered by Google App Engine
This is Rietveld 408576698