Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl.h

Issue 2871223002: memory-infra: add ProcessType and expose data in RequestGlobalDump() (Closed)
Patch Set: review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/memory/coordinator/coordinator_impl.h
diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl.h b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
index da41c42e9995a9538ea2c32b829ee794522a26fb..096847b0f9aca14eb9cda21ab6d67f99d1cca09f 100644
--- a/services/resource_coordinator/memory/coordinator/coordinator_impl.h
+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
@@ -6,8 +6,8 @@
#define SERVICES_RESOURCE_COORDINATOR_MEMORY_COORDINATOR_COORDINATOR_IMPL_H_
#include <list>
+#include <map>
#include <set>
-#include <unordered_map>
#include "base/memory/ref_counted.h"
#include "base/threading/thread_checker.h"
@@ -45,6 +45,9 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
~QueuedMemoryDumpRequest();
const base::trace_event::MemoryDumpRequestArgs args;
const RequestGlobalMemoryDumpCallback callback;
+
+ // Collects the data received from OnProcessMemoryDumpResponse().
+ std::vector<mojom::ProcessMemoryDumpPtr> process_memory_dumps;
};
~CoordinatorImpl() override;
@@ -69,8 +72,7 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
mojom::ProcessLocalDumpManager* process_manager,
uint64_t dump_guid,
bool success,
- const base::Optional<base::trace_event::MemoryDumpCallbackResult>&
- result);
+ mojom::ProcessMemoryDumpPtr process_memory_dump);
void PerformNextQueuedGlobalMemoryDump();
void FinalizeGlobalMemoryDumpIfAllManagersReplied();
@@ -78,8 +80,7 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
mojo::BindingSet<mojom::Coordinator> bindings_;
// Registered ProcessLocalDumpManagers.
- std::unordered_map<mojom::ProcessLocalDumpManager*,
- mojom::ProcessLocalDumpManagerPtr>
+ std::map<mojom::ProcessLocalDumpManager*, mojom::ProcessLocalDumpManagerPtr>
process_managers_;
// Pending process managers for RequestGlobalMemoryDump.

Powered by Google App Engine
This is Rietveld 408576698