Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl.h

Issue 2871223002: memory-infra: add ProcessType and expose data in RequestGlobalDump() (Closed)
Patch Set: add comments and propagate extra_processes_dump Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/memory/coordinator/coordinator_impl.h
diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl.h b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
index da41c42e9995a9538ea2c32b829ee794522a26fb..4ecc45794b48f0793151950ccd7bc964c98cc2af 100644
--- a/services/resource_coordinator/memory/coordinator/coordinator_impl.h
+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
@@ -69,8 +69,7 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
mojom::ProcessLocalDumpManager* process_manager,
uint64_t dump_guid,
bool success,
- const base::Optional<base::trace_event::MemoryDumpCallbackResult>&
- result);
+ mojom::ProcessMemoryDumpPtr process_memory_dump);
void PerformNextQueuedGlobalMemoryDump();
void FinalizeGlobalMemoryDumpIfAllManagersReplied();
@@ -87,6 +86,11 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
int failed_memory_dump_count_;
std::list<QueuedMemoryDumpRequest> queued_memory_dump_requests_;
+ // When a global dump is pending (i.e. !|pending_process_managers_|.empty())
+ // this object accumulates the responses received by the various clients
+ // through OnProcessMemoryDumpResponse(). nullptr when no dump is pending.
+ mojom::GlobalMemoryDumpPtr pending_global_memory_dump_;
+
const bool initialize_memory_dump_manager_;
base::ThreadChecker thread_checker_;

Powered by Google App Engine
This is Rietveld 408576698