Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.h

Issue 2871223002: memory-infra: add ProcessType and expose data in RequestGlobalDump() (Closed)
Patch Set: review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_PROCESS_LOCAL_DUMP_MANAG ER_IMPL_H_ 5 #ifndef SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_PROCESS_LOCAL_DUMP_MANAG ER_IMPL_H_
6 #define SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_PROCESS_LOCAL_DUMP_MANAG ER_IMPL_H_ 6 #define SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_PROCESS_LOCAL_DUMP_MANAG ER_IMPL_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/synchronization/lock.h" 10 #include "base/synchronization/lock.h"
(...skipping 15 matching lines...) Expand all
26 // no Coordinator service in child processes. So, in a child process, the 26 // no Coordinator service in child processes. So, in a child process, the
27 // local dump manager remotely connects to the Coordinator service. In the 27 // local dump manager remotely connects to the Coordinator service. In the
28 // browser process, it locally connects to the Coordinator service. 28 // browser process, it locally connects to the Coordinator service.
29 class SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_EXPORT 29 class SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_EXPORT
30 ProcessLocalDumpManagerImpl 30 ProcessLocalDumpManagerImpl
31 : public NON_EXPORTED_BASE(mojom::ProcessLocalDumpManager) { 31 : public NON_EXPORTED_BASE(mojom::ProcessLocalDumpManager) {
32 public: 32 public:
33 class SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_EXPORT Config { 33 class SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_EXPORT Config {
34 public: 34 public:
35 Config(service_manager::Connector* connector, 35 Config(service_manager::Connector* connector,
36 const std::string& service_name) 36 const std::string& service_name,
37 mojom::ProcessType process_type)
37 : connector_(connector), 38 : connector_(connector),
38 service_name_(service_name), 39 service_name_(service_name),
40 process_type_(process_type),
39 coordinator_(nullptr) {} 41 coordinator_(nullptr) {}
40 Config(Coordinator* coordinator) 42 Config(Coordinator* coordinator, mojom::ProcessType process_type)
41 : connector_(nullptr), coordinator_(coordinator) {} 43 : connector_(nullptr),
44 process_type_(process_type),
45 coordinator_(coordinator) {}
42 ~Config(); 46 ~Config();
43 47
44 service_manager::Connector* connector() const { return connector_; } 48 service_manager::Connector* connector() const { return connector_; }
45 49
46 const std::string& service_name() const { return service_name_; } 50 const std::string& service_name() const { return service_name_; }
47 51
52 mojom::ProcessType process_type() const { return process_type_; }
53
48 Coordinator* coordinator() const { return coordinator_; } 54 Coordinator* coordinator() const { return coordinator_; }
49 55
50 private: 56 private:
51 service_manager::Connector* connector_; 57 service_manager::Connector* connector_;
52 const std::string service_name_; 58 const std::string service_name_;
59 const mojom::ProcessType process_type_;
53 Coordinator* coordinator_; 60 Coordinator* coordinator_;
54 bool is_test_config_; 61 bool is_test_config_;
55 }; 62 };
56 63
57 static void CreateInstance(const Config& config); 64 static void CreateInstance(const Config& config);
58 65
59 // Implements base::trace_event::MemoryDumpManager::RequestGlobalDumpCallback. 66 // Implements base::trace_event::MemoryDumpManager::RequestGlobalDumpCallback.
60 // NOTE: Use MemoryDumpManager::RequestGlobalDump() to request gobal dump. 67 // NOTE: Use MemoryDumpManager::RequestGlobalDump() to request gobal dump.
61 void RequestGlobalMemoryDump( 68 void RequestGlobalMemoryDump(
62 const base::trace_event::MemoryDumpRequestArgs& args, 69 const base::trace_event::MemoryDumpRequestArgs& args,
63 const base::trace_event::GlobalMemoryDumpCallback& callback); 70 const base::trace_event::GlobalMemoryDumpCallback& callback);
64 71
65 Config config() { return config_; } 72 Config config() { return config_; }
66 void SetAsNonCoordinatorForTesting(); 73 void SetAsNonCoordinatorForTesting();
67 74
68 private: 75 private:
69 friend std::default_delete<ProcessLocalDumpManagerImpl>; // For testing 76 friend std::default_delete<ProcessLocalDumpManagerImpl>; // For testing
70 friend class ProcessLocalDumpManagerImplTest; // For testing 77 friend class ProcessLocalDumpManagerImplTest; // For testing
71 78
72 ProcessLocalDumpManagerImpl(const Config& config); 79 ProcessLocalDumpManagerImpl(const Config& config);
73 ~ProcessLocalDumpManagerImpl() override; 80 ~ProcessLocalDumpManagerImpl() override;
74 81
75 // The ProcessLocalDumpManager interface. The coordinator calls this. 82 // The ProcessLocalDumpManager interface. The coordinator calls this.
76 void RequestProcessMemoryDump( 83 void RequestProcessMemoryDump(
77 const base::trace_event::MemoryDumpRequestArgs& args, 84 const base::trace_event::MemoryDumpRequestArgs& args,
78 const RequestProcessMemoryDumpCallback& callback) override; 85 const RequestProcessMemoryDumpCallback& callback) override;
79 86
87 // Callback passed to base::MemoryDUmpManager::CreateProcessDump().
88 void OnProcessMemoryDumpDone(
89 const RequestProcessMemoryDumpCallback&,
90 uint64_t dump_guid,
91 bool success,
92 const base::Optional<base::trace_event::MemoryDumpCallbackResult>&);
93
80 // A proxy callback for updating |pending_memory_dump_guid_|. 94 // A proxy callback for updating |pending_memory_dump_guid_|.
81 void MemoryDumpCallbackProxy( 95 void MemoryDumpCallbackProxy(
82 const base::trace_event::GlobalMemoryDumpCallback& callback, 96 const base::trace_event::GlobalMemoryDumpCallback& callback,
83 uint64_t dump_guid, 97 uint64_t dump_guid,
84 bool success); 98 bool success,
99 mojom::GlobalMemoryDumpPtr global_memory_dump);
85 100
86 mojom::CoordinatorPtr coordinator_; 101 mojom::CoordinatorPtr coordinator_;
87 mojo::Binding<mojom::ProcessLocalDumpManager> binding_; 102 mojo::Binding<mojom::ProcessLocalDumpManager> binding_;
88 const Config config_; 103 const Config config_;
89 scoped_refptr<base::SingleThreadTaskRunner> task_runner_; 104 scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
90 uint64_t pending_memory_dump_guid_; 105 uint64_t pending_memory_dump_guid_;
91 106
92 base::Lock pending_memory_dump_guid_lock_; 107 base::Lock pending_memory_dump_guid_lock_;
93 108
94 DISALLOW_COPY_AND_ASSIGN(ProcessLocalDumpManagerImpl); 109 DISALLOW_COPY_AND_ASSIGN(ProcessLocalDumpManagerImpl);
95 }; 110 };
96 111
97 } // namespace memory_instrumentation 112 } // namespace memory_instrumentation
98 113
99 #endif // SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_PROCESS_LOCAL_DUMP_MA NAGER_IMPL_H_ 114 #endif // SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_PROCESS_LOCAL_DUMP_MA NAGER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698