headless/lib/headless_web_contents_browsertest.cc - Issue 2871113002: Change from_surface default value to true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/headless_web_contents_browsertest.cc

Issue 2871113002: Change from_surface default value to true (Closed)

Patch Set: revert to defaulting to true Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/headless_web_contents_browsertest.cc

diff --git a/headless/lib/headless_web_contents_browsertest.cc b/headless/lib/headless_web_contents_browsertest.cc

index 9d92f2a2642921309d23180c667fe5d407be2109..8059c39c50356f5be642315a81038c185b26b91a 100644

--- a/headless/lib/headless_web_contents_browsertest.cc

+++ b/headless/lib/headless_web_contents_browsertest.cc

@@ -161,7 +161,7 @@ class HeadlessWebContentsScreenshotTest

void OnPageSetupCompleted(std::unique_ptr<runtime::EvaluateResult> result) {

devtools_client_->GetPage()->GetExperimental()->CaptureScreenshot(

- page::CaptureScreenshotParams::Builder().SetFromSurface(true).Build(),

+ page::CaptureScreenshotParams::Builder().Build(),

base::Bind(&HeadlessWebContentsScreenshotTest::OnScreenshotCaptured,

base::Unretained(this)));

}