content/browser/devtools/protocol/page_handler.cc - Issue 2871113002: Change from_surface default value to true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 2871113002: Change from_surface default value to true (Closed)

Patch Set: revert to defaulting to true Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/page_handler.cc

diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc

index 3e7f34559424b74408de893a9a1e2dccf6d80750..3b4ac83a030a049e4586717b962308bb10cdf388 100644

--- a/content/browser/devtools/protocol/page_handler.cc

+++ b/content/browser/devtools/protocol/page_handler.cc

@@ -296,7 +296,7 @@ void PageHandler::CaptureScreenshot(

base::Bind(&PageHandler::ScreenshotCaptured, weak_factory_.GetWeakPtr(),

base::Passed(std::move(callback)), screenshot_format,

screenshot_quality),

- from_surface.fromMaybe(false));

+ from_surface.fromMaybe(true));

}

void PageHandler::PrintToPDF(Maybe<bool> landscape,

« no previous file with comments | « no previous file | headless/app/headless_shell.cc » ('j') | no next file with comments »