Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2871113002: Change from_surface default value to true (Closed)
Patch Set: remove headless fromSurface Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « headless/lib/headless_web_contents_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "version": { "major": "1", "minor": "2" }, 2 "version": { "major": "1", "minor": "2" },
3 "domains": [{ 3 "domains": [{
4 "domain": "Inspector", 4 "domain": "Inspector",
5 "experimental": true, 5 "experimental": true,
6 "types": [], 6 "types": [],
7 "commands": [ 7 "commands": [
8 { 8 {
9 "name": "enable", 9 "name": "enable",
10 "description": "Enables inspector domain notifications." 10 "description": "Enables inspector domain notifications."
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 "description": "Toggles mouse event-based touch event emulation. ", 413 "description": "Toggles mouse event-based touch event emulation. ",
414 "experimental": true, 414 "experimental": true,
415 "redirect": "Emulation" 415 "redirect": "Emulation"
416 }, 416 },
417 { 417 {
418 "name": "captureScreenshot", 418 "name": "captureScreenshot",
419 "description": "Capture page screenshot.", 419 "description": "Capture page screenshot.",
420 "parameters": [ 420 "parameters": [
421 { "name": "format", "type": "string", "optional": true, "enu m": ["jpeg", "png"], "description": "Image compression format (defaults to png). " }, 421 { "name": "format", "type": "string", "optional": true, "enu m": ["jpeg", "png"], "description": "Image compression format (defaults to png). " },
422 { "name": "quality", "type": "integer", "optional": true, "d escription": "Compression quality from range [0..100] (jpeg only)." }, 422 { "name": "quality", "type": "integer", "optional": true, "d escription": "Compression quality from range [0..100] (jpeg only)." },
423 { "name": "fromSurface", "type": "boolean", "optional": true , "description": "Capture the screenshot from the surface, rather than the view. Defaults to false.", "experimental": true } 423 { "name": "fromSurface", "type": "boolean", "optional": true , "description": "Capture the screenshot from the surface, rather than the view. Defaults to true."}
Eric Seckler 2017/05/11 07:34:18 I'd keep "experimental": true, if we want to get r
dgozman 2017/05/11 20:48:05 +1
dvallet 2017/05/12 05:45:21 Done
424 ], 424 ],
425 "returns": [ 425 "returns": [
426 { "name": "data", "type": "string", "description": "Base64-e ncoded image data." } 426 { "name": "data", "type": "string", "description": "Base64-e ncoded image data." }
427 ], 427 ],
428 "experimental": true 428 "experimental": true
429 }, 429 },
430 { 430 {
431 "name": "printToPDF", 431 "name": "printToPDF",
432 "description": "Print page as PDF.", 432 "description": "Print page as PDF.",
433 "parameters": [ 433 "parameters": [
(...skipping 4228 matching lines...) Expand 10 before | Expand all | Expand 10 after
4662 "parameters": [ 4662 "parameters": [
4663 { "name": "windowId", "$ref": "WindowID", "description": "Br owser window id." } 4663 { "name": "windowId", "$ref": "WindowID", "description": "Br owser window id." }
4664 ], 4664 ],
4665 "returns": [ 4665 "returns": [
4666 { "name": "bounds", "$ref": "Bounds", "description": "Bounds information of the window. When window state is 'minimized', the restored windo w position and size are returned." } 4666 { "name": "bounds", "$ref": "Bounds", "description": "Bounds information of the window. When window state is 'minimized', the restored windo w position and size are returned." }
4667 ] 4667 ]
4668 } 4668 }
4669 ] 4669 ]
4670 }] 4670 }]
4671 } 4671 }
OLDNEW
« no previous file with comments | « headless/lib/headless_web_contents_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698