Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: chrome/browser/ui/browser_dialogs.h

Issue 2871073002: cros: Bind hangup red button on remote controller to close web dialog (Closed)
Patch Set: feedback from xiyuan Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_dialogs.h
diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h
index 9ece1b6d7476bb1f2223222550e83b4e4f1fa9ca..9b15a11b6272380e586ebd373d5d851fd2349ab8 100644
--- a/chrome/browser/ui/browser_dialogs.h
+++ b/chrome/browser/ui/browser_dialogs.h
@@ -94,11 +94,12 @@ gfx::NativeWindow ShowWebDialog(gfx::NativeView parent,
#if defined(USE_ASH)
// Creates and shows an HTML dialog with the given delegate and browser context.
// The dialog is placed in the ash window hierarchy in the given container.
+// Returns the created window.
sky 2017/05/11 15:04:11 Document the lifetime of the returned window and w
Qiang(Joe) Xu 2017/05/12 21:50:45 Add the same comment as above: The window is autom
// See ash/public/cpp/shell_window_ids.h for |container_id| values. The window
// is destroyed when it is closed. See also chrome::ShowWebDialog().
-void ShowWebDialogInContainer(int container_id,
- content::BrowserContext* context,
- ui::WebDialogDelegate* delegate);
+gfx::NativeWindow ShowWebDialogInContainer(int container_id,
+ content::BrowserContext* context,
+ ui::WebDialogDelegate* delegate);
#endif // defined(USE_ASH)
// Shows the create chrome app shortcut dialog box.

Powered by Google App Engine
This is Rietveld 408576698