Introduce ability to register callback with GoogleURLTracker

chrome/browser/search_engines/search_provider_install_data_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 224 matching lines @@
   TestGetInstallState test_get_install_state(install_data_);
   test_get_install_state.RunTests(host, host2);
 }
 
 TEST_F(SearchProviderInstallDataTest, GoogleBaseUrlChange) {
   TestGetInstallState test_get_install_state(install_data_);
 
   // Set up the database.
   util_.ChangeModelToLoadState();
   std::string google_host = "w.com";
-  util_.SetGoogleBaseURL(GURL("http://" + google_host + "/"));
+  GURL new_url = GURL("http://" + google_host + "/");
+  util_.SetGoogleBaseURL(new_url);
+  BrowserThread::PostTask(

[blundell, 2014/05/15 20:58:00]

This was the most straightforward way that I could find to migrate the test to
the new code organization given that GoogleURLObserver and
GoogleURLChangeNotifier are internal classes to SearchProviderInstallData. Let
me know if you see anything else as a more appealing option.

[Peter Kasting, 2014/05/15 21:12:52]

At least put all this code in a protected helper in
SearchProviderInstallDataTest instead of pasting it twice.

[blundell, 2014/05/16 09:09:55]

Done.

+      BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(&SearchProviderInstallData::OnGoogleURLChange,
+                 base::Unretained(install_data_),
+                 new_url.spec()));
   // Wait for the I/O thread to process the update notification.
   base::RunLoop().RunUntilIdle();
 
   AddNewTemplateURL("{google:baseURL}?q={searchTerms}",
                     base::ASCIIToUTF16("t"));
   TemplateURL* default_url =
       AddNewTemplateURL("http://d.com/", base::ASCIIToUTF16("d"));
   util_.model()->SetUserSelectedDefaultSearchProvider(default_url);
 
   // Wait for the changes to be saved.
   base::RunLoop().RunUntilIdle();
 
   // Verify the search providers install state (with no default set).
   test_get_install_state.RunTests(google_host, std::string());
 
   // Change the Google base url.
   google_host = "foo.com";
-  util_.SetGoogleBaseURL(GURL("http://" + google_host + "/"));
+  new_url = GURL("http://" + google_host + "/");
+  util_.SetGoogleBaseURL(new_url);
+  BrowserThread::PostTask(
+      BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(&SearchProviderInstallData::OnGoogleURLChange,
+                 base::Unretained(install_data_),
+                 new_url.spec()));
   // Wait for the I/O thread to process the update notification.
   base::RunLoop().RunUntilIdle();
 
   // Verify that the change got picked up.
   test_get_install_state.RunTests(google_host, std::string());
 }