Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Issue 2871013002: [subresource_filter] Refactor activation suppression (Closed)
Patch Set: just remove the suppression call Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
index d89d37cd34065c10c6b7852eaec9242348672d55..482778287962f8073fb32fb233b77774dac35273 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
@@ -119,9 +119,7 @@ ContentSubresourceFilterDriverFactory::
if (!url.SchemeIsHTTPOrHTTPS())
return ActivationDecision::UNSUPPORTED_SCHEME;
- // TODO(csharrison): The throttle manager also performs this check. Remove
- // this one when the activation decision is sent directly to the throttle
- // manager.
+
if (client_->ShouldSuppressActivation(navigation_handle))
return ActivationDecision::URL_WHITELISTED;
@@ -219,11 +217,6 @@ void ContentSubresourceFilterDriverFactory::OnFirstSubresourceLoadDisallowed() {
ActivationLevel::ENABLED);
}
-bool ContentSubresourceFilterDriverFactory::ShouldSuppressActivation(
- content::NavigationHandle* navigation_handle) {
- return client_->ShouldSuppressActivation(navigation_handle);
-}
-
void ContentSubresourceFilterDriverFactory::ResetActivationState() {
navigation_chain_.clear();
activation_list_matches_.clear();

Powered by Google App Engine
This is Rietveld 408576698