Issue 287093004: Revert r271097 - "Add most of the metadata-handling code for blobs."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287093004: Revert r271097 - "Add most of the metadata-handling code for blobs." (Closed)

Created:
6 years, 7 months ago by Dirk Pranke

Modified:
6 years, 7 months ago

Reviewers:
ericu

CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert r271097 - "Add most of the metadata-handling code for blobs." This change caused most of the indexeddb tests to fail on win7 :(. TBR=ericu@chromium.org BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271146

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -394 lines)			Patch
M	content/browser/indexed_db/indexed_db_backing_store.h	View	4 chunks	+2 lines, -13 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_backing_store.cc	View	37 chunks	+54 lines, -379 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_leveldb_coding.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Committed patchset #1 manually as r271146 (tree was closed).

6 years, 7 months ago (2014-05-17 01:53:51 UTC) #2

ericu

I don't know what happened; I thought I did this via drover before leaving the ...

6 years, 7 months ago (2014-05-17 01:57:19 UTC) #3

Dirk Pranke

6 years, 7 months ago (2014-05-17 03:14:59 UTC) #4

Message was sent while issue was closed.

On 2014/05/17 01:57:19, ericu wrote:
> I don't know what happened; I thought I did this via drover before
> leaving the office.
> I'll take a look at my console scrollback when I'm in on Monday.
> 
> Thanks for cleaning up for me.
> 

No problem; I figured you needed to leave in a hurry and it would've been easy
to miss a prompt or something.

Expand Messages | Collapse Messages