Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 287083004: Fix the string resource used to indicate MHTML save type (Closed)

Created:
6 years, 7 months ago by hashimoto
Modified:
6 years, 7 months ago
Reviewers:
joshwoodward1, kinaba
CC:
chromium-reviews, joshwoodward1, asanka
Visibility:
Public.

Description

Fix the string resource used to indicate MHTML save type BUG=369875 TEST=On a Chromebook, try to save a web page and see the file type selector. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
cc: joshwoodward, asanka FYI From https://code.google.com/p/chromium/issues/detail?id=373659#c3 This string was added in https://codereview.chromium.org/269413002/.
6 years, 7 months ago (2014-05-16 05:25:36 UTC) #1
kinaba
lgtm
6 years, 7 months ago (2014-05-16 05:26:34 UTC) #2
joshwoodward1
LGTM On May 15, 2014 10:26 PM, <kinaba@chromium.org> wrote: > lgtm > > > > ...
6 years, 7 months ago (2014-05-16 05:27:07 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 7 months ago (2014-05-16 05:28:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/287083004/1
6 years, 7 months ago (2014-05-16 05:28:26 UTC) #5
commit-bot: I haz the power
Change committed as 270955
6 years, 7 months ago (2014-05-16 07:56:17 UTC) #6
joshwoodward1
6 years, 7 months ago (2014-05-16 13:51:40 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698