Index: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc |
diff --git a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc |
index d91e5b339994392d7f211c1b8f290b82ef7c27c2..3647802ec10b6ddc1bf008b4055cefb85a534bf2 100644 |
--- a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc |
+++ b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc |
@@ -29,7 +29,6 @@ |
#include "chrome/browser/chromeos/policy/device_policy_cros_browser_test.h" |
#include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h" |
#include "chrome/browser/chromeos/settings/cros_settings.h" |
-#include "chrome/common/chrome_switches.h" |
#include "chrome/test/base/testing_browser_process.h" |
#include "chrome/test/base/testing_profile.h" |
#include "chrome/test/base/ui_test_utils.h" |
@@ -80,8 +79,7 @@ ACTION_P2(CreateAuthenticator, username, password) { |
} // namespace |
-class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest, |
- public testing::WithParamInterface<bool> { |
+class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest { |
protected: |
ExistingUserControllerTest() |
: mock_login_display_(NULL), mock_user_manager_(NULL) {} |
@@ -127,8 +125,6 @@ class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest, |
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { |
command_line->AppendSwitch(switches::kLoginManager); |
- if (GetParam()) |
- command_line->AppendSwitch(::switches::kMultiProfiles); |
} |
virtual void SetUpUserManager() { |
@@ -233,7 +229,7 @@ class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest, |
DISALLOW_COPY_AND_ASSIGN(ExistingUserControllerTest); |
}; |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, ExistingUserLogin) { |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest, ExistingUserLogin) { |
// This is disabled twice: once right after signin but before checking for |
// auto-enrollment, and again after doing an ownership status check. |
EXPECT_CALL(*mock_login_display_, SetUIEnabled(false)) |
@@ -267,7 +263,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, ExistingUserLogin) { |
content::RunAllPendingInMessageLoop(); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, AutoEnrollAfterSignIn) { |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest, AutoEnrollAfterSignIn) { |
EXPECT_CALL(*mock_login_display_host_, |
StartWizardPtr(WizardController::kEnrollmentScreenName, |
_)) |
@@ -294,7 +290,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, AutoEnrollAfterSignIn) { |
content::RunAllPendingInMessageLoop(); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest, |
NewUserDontAutoEnrollAfterSignIn) { |
EXPECT_CALL(*mock_login_display_host_, |
StartWizardPtr(WizardController::kEnrollmentScreenName, |
@@ -524,7 +520,7 @@ class ExistingUserControllerPublicSessionTest |
DISALLOW_COPY_AND_ASSIGN(ExistingUserControllerPublicSessionTest); |
}; |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
ConfigureAutoLoginUsingPolicy) { |
existing_user_controller()->OnSigninScreenReady(); |
EXPECT_EQ("", auto_login_username()); |
@@ -546,7 +542,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
EXPECT_FALSE(auto_login_timer()->IsRunning()); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
AutoLoginNoDelay) { |
// Set up mocks to check login success. |
ExpectSuccessfulLogin(public_session_user_id_, ""); |
@@ -557,7 +553,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
content::RunAllPendingInMessageLoop(); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
AutoLoginShortDelay) { |
// Set up mocks to check login success. |
ExpectSuccessfulLogin(public_session_user_id_, ""); |
@@ -580,7 +576,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
content::RunAllPendingInMessageLoop(); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
LoginStopsAutoLogin) { |
// Set up mocks to check login success. |
ExpectSuccessfulLogin(kUsername, kPassword); |
@@ -603,7 +599,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
EXPECT_FALSE(auto_login_timer()->IsRunning()); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
GuestModeLoginStopsAutoLogin) { |
EXPECT_CALL(*mock_login_display_, SetUIEnabled(false)) |
.Times(1); |
@@ -631,7 +627,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
EXPECT_FALSE(auto_login_timer()->IsRunning()); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
CompleteLoginStopsAutoLogin) { |
// Set up mocks to check login success. |
ExpectSuccessfulLogin(kUsername, kPassword); |
@@ -656,7 +652,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
EXPECT_FALSE(auto_login_timer()->IsRunning()); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
PublicSessionLoginStopsAutoLogin) { |
// Set up mocks to check login success. |
ExpectSuccessfulLogin(public_session_user_id_, ""); |
@@ -678,22 +674,14 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
EXPECT_FALSE(auto_login_timer()->IsRunning()); |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
PRE_TestLoadingPublicUsersFromLocalState) { |
// First run propagates public accounts and stores them in Local State. |
} |
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest, |
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest, |
TestLoadingPublicUsersFromLocalState) { |
// Second run loads list of public accounts from Local State. |
} |
-INSTANTIATE_TEST_CASE_P(ExistingUserControllerTestInstantiation, |
- ExistingUserControllerTest, |
- testing::Bool()); |
- |
-INSTANTIATE_TEST_CASE_P(ExistingUserControllerPublicSessionTestInstantiation, |
- ExistingUserControllerPublicSessionTest, |
- testing::Bool()); |
- |
} // namespace chromeos |