Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

Issue 287083003: Multi-profile flag cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
index d91e5b339994392d7f211c1b8f290b82ef7c27c2..c892851c5fef795ff836ad7bb1e40fd9bae21f0b 100644
--- a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
@@ -80,8 +80,7 @@ ACTION_P2(CreateAuthenticator, username, password) {
} // namespace
-class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest,
- public testing::WithParamInterface<bool> {
+class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest {
protected:
ExistingUserControllerTest()
: mock_login_display_(NULL), mock_user_manager_(NULL) {}
@@ -127,8 +126,6 @@ class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest,
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
command_line->AppendSwitch(switches::kLoginManager);
- if (GetParam())
- command_line->AppendSwitch(::switches::kMultiProfiles);
}
virtual void SetUpUserManager() {
@@ -233,7 +230,7 @@ class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest,
DISALLOW_COPY_AND_ASSIGN(ExistingUserControllerTest);
};
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, ExistingUserLogin) {
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest, ExistingUserLogin) {
// This is disabled twice: once right after signin but before checking for
// auto-enrollment, and again after doing an ownership status check.
EXPECT_CALL(*mock_login_display_, SetUIEnabled(false))
@@ -267,7 +264,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, ExistingUserLogin) {
content::RunAllPendingInMessageLoop();
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, AutoEnrollAfterSignIn) {
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest, AutoEnrollAfterSignIn) {
EXPECT_CALL(*mock_login_display_host_,
StartWizardPtr(WizardController::kEnrollmentScreenName,
_))
@@ -294,7 +291,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest, AutoEnrollAfterSignIn) {
content::RunAllPendingInMessageLoop();
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest,
NewUserDontAutoEnrollAfterSignIn) {
EXPECT_CALL(*mock_login_display_host_,
StartWizardPtr(WizardController::kEnrollmentScreenName,
@@ -524,7 +521,7 @@ class ExistingUserControllerPublicSessionTest
DISALLOW_COPY_AND_ASSIGN(ExistingUserControllerPublicSessionTest);
};
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
ConfigureAutoLoginUsingPolicy) {
existing_user_controller()->OnSigninScreenReady();
EXPECT_EQ("", auto_login_username());
@@ -546,7 +543,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
EXPECT_FALSE(auto_login_timer()->IsRunning());
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
AutoLoginNoDelay) {
// Set up mocks to check login success.
ExpectSuccessfulLogin(public_session_user_id_, "");
@@ -557,7 +554,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
content::RunAllPendingInMessageLoop();
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
AutoLoginShortDelay) {
// Set up mocks to check login success.
ExpectSuccessfulLogin(public_session_user_id_, "");
@@ -580,7 +577,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
content::RunAllPendingInMessageLoop();
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
LoginStopsAutoLogin) {
// Set up mocks to check login success.
ExpectSuccessfulLogin(kUsername, kPassword);
@@ -603,7 +600,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
EXPECT_FALSE(auto_login_timer()->IsRunning());
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
GuestModeLoginStopsAutoLogin) {
EXPECT_CALL(*mock_login_display_, SetUIEnabled(false))
.Times(1);
@@ -631,7 +628,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
EXPECT_FALSE(auto_login_timer()->IsRunning());
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
CompleteLoginStopsAutoLogin) {
// Set up mocks to check login success.
ExpectSuccessfulLogin(kUsername, kPassword);
@@ -656,7 +653,7 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
EXPECT_FALSE(auto_login_timer()->IsRunning());
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
PublicSessionLoginStopsAutoLogin) {
// Set up mocks to check login success.
ExpectSuccessfulLogin(public_session_user_id_, "");
@@ -678,22 +675,14 @@ IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
EXPECT_FALSE(auto_login_timer()->IsRunning());
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
PRE_TestLoadingPublicUsersFromLocalState) {
// First run propagates public accounts and stores them in Local State.
}
-IN_PROC_BROWSER_TEST_P(ExistingUserControllerPublicSessionTest,
+IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
TestLoadingPublicUsersFromLocalState) {
// Second run loads list of public accounts from Local State.
}
-INSTANTIATE_TEST_CASE_P(ExistingUserControllerTestInstantiation,
- ExistingUserControllerTest,
- testing::Bool());
-
-INSTANTIATE_TEST_CASE_P(ExistingUserControllerPublicSessionTestInstantiation,
- ExistingUserControllerPublicSessionTest,
- testing::Bool());
-
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698