Multi-profile flag cleanup

chrome/common/chrome_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 
 namespace switches {
@@ skipping 870 matching lines @@
 const char kMessageLoopHistogrammer[]       = "message-loop-histogrammer";
 
 // Enables the recording of metrics reports but disables reporting. In contrast
 // to kDisableMetrics, this executes all the code that a normal client would
 // use for reporting, except the report is dropped rather than sent to the
 // server. This is useful for finding issues in the metrics code during UI and
 // performance tests.
 const char kMetricsRecordingOnly[]          = "metrics-recording-only";
 
 // Enables multiprofile Chrome.
-const char kMultiProfiles[]                 = "multi-profiles";
+// TODO(zelidrag): Remove this one completely in M-38+ once most profiles

[Nikita (slow), 2014/05/19 14:27:15]

What about users that will update from pre-M-37 profiles and will miss that
migration process? I assume non-existing flags should just get ignored somehow
and don't require Chrome browser process restart.

[zel, 2014/05/19 18:06:27]

Actually, it seems that we don't have to do this type of filtering at all since
FlagsState::ConvertFlagsToSwitches()/GetSanitizedEnabledFlagsForCurrentPlatform()
takes care for this.

Removed.

+// that got infected with it through about://flags are cleaned.
+const char kMultiProfilesObsolete[]         = "multi-profiles";
 
 // Sets the base logging level for the net log. Log 0 logs the most data.
 // Intended primarily for use with --log-net-log.
 const char kNetLogLevel[]                   = "net-log-level";
 
 // Disables the default browser check. Useful for UI/browser tests where we
 // want to avoid having the default browser info-bar displayed.
 const char kNoDefaultBrowserCheck[]         = "no-default-browser-check";
 
 // By default, an https page can load images, fonts or frames from an http
@@ skipping 557 matching lines @@
 
 // -----------------------------------------------------------------------------
 // DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE.
 //
 // You were going to just dump your switches here, weren't you? Instead, please
 // put them in alphabetical order above, or in order inside the appropriate
 // ifdef at the bottom. The order should match the header.
 // -----------------------------------------------------------------------------
 
 }  // namespace switches