Issue 2870773004: Fix dart2js co19 tests to fix unexpected DRT passes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2870773004: Fix dart2js co19 tests to fix unexpected DRT passes (Closed)

Created:
3 years, 7 months ago by erikcorry

Modified:
3 years, 7 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix dart2js co19 tests to fix unexpected DRT passes R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6a1560b54100afd10877fbaf6dbeee761c8b201e

Patch Set 1 #

Total comments: 1

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	tests/co19/co19-dart2js.status	View		4 chunks	+1 line, -4 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

https://codereview.chromium.org/2870773004/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2870773004/diff/1/tests/co19/co19-dart2js.status#newcode396 tests/co19/co19-dart2js.status:396: LayoutTests/fast/parser/pre-first-line-break_t01: RuntimeError # Please triage this failure Please keep ...

3 years, 7 months ago (2017-05-09 08:16:13 UTC) #2

erikcorry

3 years, 7 months ago (2017-05-09 08:24:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6a1560b54100afd10877fbaf6dbeee761c8b201e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages