Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: components/download/public/clients.h

Issue 2870753003: Add a Model to the download component. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/download/public/clients.h
diff --git a/components/download/public/clients.h b/components/download/public/clients.h
index 7ce237823d04496edc1fa9ad7aca4014229a9c88..d39ced936ef18fb5ca3b2013032f14a09988f500 100644
--- a/components/download/public/clients.h
+++ b/components/download/public/clients.h
@@ -16,11 +16,18 @@ namespace download {
// download with the right client.
enum class DownloadClient {
// Represents an uninitialized DownloadClient variable.
- DOWNLOAD_CLIENT_INVALID = 0,
+ INVALID = 0,
- DOWNLOAD_CLIENT_OFFLINE_PAGE_PREFETCH = 1,
+ // Test client values. Meant to be used by the testing framework and not
+ // production code. Callers will be unable to access the DownloadService with
+ // these test APIs.
+ TEST_1 = 1,
+ TEST_2 = 2,
+ TEST_3 = 3,
xingliu 2017/05/09 06:11:41 optional nit: this is more like something in tests
David Trainor- moved to gerrit 2017/05/09 15:59:26 Me neither... I don't want to rely on a client alw
Peter Beverloo 2017/05/10 12:44:45 We'll have to reflect these in histograms.xml, so
David Trainor- moved to gerrit 2017/05/15 15:59:52 Good point r.e. UMA. I'll leave it at 1. If we e
- DOWNLOAD_CLIENT_BOUNDARY = 2,
+ OFFLINE_PAGE_PREFETCH = 4,
+
+ BOUNDARY = 5,
};
} // namespace download

Powered by Google App Engine
This is Rietveld 408576698