Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2870713002: Avoid error in Observatory about trying to load file not included in the Observatory assets. (Closed)

Created:
3 years, 7 months ago by rmacnak
Modified:
3 years, 7 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid error in Observatory about trying to load file not included in the Observatory assets. Related to issue #29577 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/c301c62b1f5d07090e165c5aa3c29788ee7515da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M runtime/observatory/tests/observatory_ui/allocation_profile/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/class_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/class_tree/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/code_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/context_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/context_view/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/cpu_profile/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/cpu_profile_table/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/curly_block/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/error_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/error_view/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/field_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/flag_list/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/function_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/general_error/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/heap_snapshot/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/icdata_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/icdata_view/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/inbound_references/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/instance_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate/counter_chart/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate_reconnect/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/library_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/local_var_descriptor_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/megamorphiccache_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/library-menu/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_exception/exception_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/refresh/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/top_menu/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/vm_menu/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/object_common/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/objectpool_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/objectpool_view/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/objectstore_view/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/ports/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/retaining_path/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/script_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/sentinel_value/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/source_link/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/token_stream_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/unknown_ref/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/view_footer/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/vm_connect/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/web/index.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
Seems to work fine in both Chrome and Dartium without this. I think it's leftover ...
3 years, 7 months ago (2017-05-08 20:08:46 UTC) #2
zra
lgtm
3 years, 7 months ago (2017-05-08 20:12:35 UTC) #3
rmacnak
3 years, 7 months ago (2017-05-08 21:00:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c301c62b1f5d07090e165c5aa3c29788ee7515da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698