Issue 287063006: Gallery: Fix property names referred in the Ribbon class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287063006: Gallery: Fix property names referred in the Ribbon class. (Closed)

Created:
6 years, 7 months ago by hirono

Modified:
6 years, 7 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Gallery: Fix property names referred in the Ribbon class. Previously the gallery's ribbon refers oldUrl property that was replaced with oldEntry. This causes a bug to fail update the ribbon's cache. BUG=373167 TEST=manually R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270947

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ui/file_manager/file_manager/foreground/js/photo/ribbon.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/file_manager/gallery/js/ribbon.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/287063006/1

6 years, 7 months ago (2014-05-16 04:57:08 UTC) #4

hirono

6 years, 7 months ago (2014-05-16 06:15:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r270947 (presubmit successful).