Issue 287063003: Correct SpdySession StreamID exhaustion behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287063003: Correct SpdySession StreamID exhaustion behavior (Closed)

Created:
6 years, 7 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Correct SpdySession StreamID exhaustion behavior If the stream ID space is exhausted, SpdySession must allow active streams to complete, but prevent new streams from being created. Change SpdySession to begin going away in this case, and add an explicit test on ID exhaustion. Also allow stream IDs to use the full 31-bit space available. BUG=373858 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271175

Patch Set 1 #

Patch Set 2 : Comment tweaks. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -7 lines)			Patch
M	net/spdy/spdy_session.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View	1	3 chunks	+13 lines, -5 lines	0 comments	Download
M	net/spdy/spdy_session_unittest.cc	View	1	1 chunk	+125 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/287063003/20001

6 years, 7 months ago (2014-05-16 18:19:54 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-16 21:23:28 UTC) #5

Message was sent while issue was closed.

Change committed as 271175

Expand Messages | Collapse Messages