Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 287063002: Revert of use canonical base URL for projects (Closed)

Created:
6 years, 7 months ago by sheyang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Sergey Berezin, Paweł Hajdan Jr., Sergiy Byelozyorov
Visibility:
Public.

Description

Revert of use canonical base URL for projects (https://codereview.chromium.org/271703010/) Reason for revert: CQ rejects all chromium projects because of this change. Original issue's description: > use canonical base URL for projects > > BUG=372645 > R=iannucci@chromium.org, sergeyberezin@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270460 TBR=iannucci@chromium.org,sergeyberezin@chromium.org NOTREECHECKS=true NOTRY=true BUG=372645 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=270803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M git_cl.py View 2 chunks +3 lines, -15 lines 0 comments Download
M tests/git_cl_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
sheyang
Created Revert of use canonical base URL for projects
6 years, 7 months ago (2014-05-15 20:39:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/287063002/1
6 years, 7 months ago (2014-05-15 20:39:48 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 20:39:49 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-15 20:39:51 UTC) #4
Dirk Pranke
lgtm.
6 years, 7 months ago (2014-05-15 20:40:14 UTC) #5
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 7 months ago (2014-05-15 20:40:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/287063002/1
6 years, 7 months ago (2014-05-15 20:41:20 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 20:43:06 UTC) #8
Message was sent while issue was closed.
Change committed as 270803

Powered by Google App Engine
This is Rietveld 408576698