Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2870583002: Revert "Update status files: these co19 tests seemed to have invalid code that got" (Closed)

Created:
3 years, 7 months ago by Bill Hesse
Modified:
3 years, 7 months ago
Reviewers:
jensj
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Update status files: these co19 tests seemed to have invalid code that got" This reverts commit dadb76a197b0b5c8493d6b63a423fd743fa0c6cb. This revert is part of reverting "Void is not required to be 'null' anymore. R=jensj@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5ffb0b2c210ee175f4abe1a13100828675a753c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tests/co19/co19-dart2js.status View 5 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
3 years, 7 months ago (2017-05-08 09:08:21 UTC) #1
jensj
lgtm
3 years, 7 months ago (2017-05-08 09:10:42 UTC) #2
Bill Hesse
3 years, 7 months ago (2017-05-08 09:14:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ffb0b2c210ee175f4abe1a13100828675a753c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698