third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h - Issue 2870543002: Removed PassRefPtr to RefPtr copies from unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

Issue 2870543002: Removed PassRefPtr to RefPtr copies from unit tests. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.h ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

index 3fd5bb3a0dc384fd114b4b449e653e27821c4f61..4fa3532a3f9969e27203b61e0d09e1e720efed1d 100644

--- a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

@@ -187,7 +187,7 @@ class DataConsumerHandleTestUtil {

public:

ReaderImpl(const String& name, PassRefPtr<Context> context)

- : name_(name.IsolatedCopy()), context_(context) {

+ : name_(name.IsolatedCopy()), context_(std::move(context)) {

context_->RecordAttach(name_.IsolatedCopy());

}

~ReaderImpl() override { context_->RecordDetach(name_.IsolatedCopy()); }

@@ -218,7 +218,7 @@ class DataConsumerHandleTestUtil {

private:

DataConsumerHandle(const String& name, PassRefPtr<Context> context)

- : name_(name.IsolatedCopy()), context_(context) {}

+ : name_(name.IsolatedCopy()), context_(std::move(context)) {}

std::unique_ptr<Reader> ObtainReader(Client*) {

return WTF::MakeUnique<ReaderImpl>(name_, context_);