Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 287053007: Add python-crypto and python-openssl for rietveld uploads to work w/ oauth. (Closed)

Created:
6 years, 7 months ago by Dirk Pranke
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, pgervais, smut, friedman, pschmidt1, johnw1
Visibility:
Public.

Description

Add python-crypto and python-openssl for rietveld uploads to work w/ oauth. In order for us to support OAuth-authenticated access to Rietveld, we need to be able to generate signed authorization requests in the Rietveld upload scripts. That requires us to have either the python OpenSSL wrappers plus OpenSSL itself installed, or to use the python pyCrypto library. Currently the bots use python-openssl, but don't work on Windows as a result. We add the python-openssl wrapper to be consistent, but want to switch to pycrypto, so once we have all the bots using pycrypto, we can drop python-openssl from the list. R=thestig@chromium.org BUG=371620, 375971 NOTRY=true Committed: https://crrev.com/fedbbb0aa762826ba2fc85a2b934dc9660639aa7 Cr-Commit-Position: refs/heads/master@{#297021}

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge to HEAD, update w/ review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M build/install-build-deps.sh View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dirk Pranke
(Note that the bots use install-build-deps to get all the packages that they need, in ...
6 years, 7 months ago (2014-05-22 00:47:59 UTC) #1
Lei Zhang
lgtm Add NOTRY=true as well? https://codereview.chromium.org/287053007/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/287053007/diff/1/build/install-build-deps.sh#newcode107 build/install-build-deps.sh:107: patch perl php5-cgi pkg-config ...
6 years, 7 months ago (2014-05-22 03:38:22 UTC) #2
Dirk Pranke
6 years, 2 months ago (2014-09-26 20:22:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/287053007/20001
6 years, 2 months ago (2014-09-26 20:23:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ab796b554747f04e7b7d91e70a1040bdf0eb1319
6 years, 2 months ago (2014-09-26 20:23:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 20:24:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fedbbb0aa762826ba2fc85a2b934dc9660639aa7
Cr-Commit-Position: refs/heads/master@{#297021}

Powered by Google App Engine
This is Rietveld 408576698