Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 287053004: SetBounds for ViewTreeNode. (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -4 lines) Patch
M mojo/mojo_examples.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 4 chunks +9 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/view_manager/DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/DEPS View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 4 chunks +44 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node.cc View 1 2 3 4 5 4 chunks +49 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node_private.h View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 3 4 5 4 chunks +49 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_tree_node_unittest.cc View 1 2 3 chunks +79 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/util.h View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_tree_node.h View 4 chunks +7 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_tree_node_observer.h View 2 chunks +9 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 3 chunks +8 lines, -0 lines 0 comments Download
M mojo/services/view_manager/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 2 3 4 5 6 7 3 chunks +11 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 3 4 5 6 7 3 chunks +39 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 2 3 4 5 6 7 6 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ben Goodger (Google)
https://codereview.chromium.org/287053004/diff/60001/mojo/services/public/cpp/view_manager/lib/DEPS File mojo/services/public/cpp/view_manager/lib/DEPS (right): https://codereview.chromium.org/287053004/diff/60001/mojo/services/public/cpp/view_manager/lib/DEPS#newcode7 mojo/services/public/cpp/view_manager/lib/DEPS:7: removed this extra nl locally. https://codereview.chromium.org/287053004/diff/60001/mojo/services/view_manager/node_delegate.h File mojo/services/view_manager/node_delegate.h (right): ...
6 years, 7 months ago (2014-05-21 21:08:12 UTC) #1
sky
LGTM with the following changes. https://codereview.chromium.org/287053004/diff/60001/mojo/services/public/interfaces/view_manager/view_manager.mojom File mojo/services/public/interfaces/view_manager/view_manager.mojom (right): https://codereview.chromium.org/287053004/diff/60001/mojo/services/public/interfaces/view_manager/view_manager.mojom#newcode39 mojo/services/public/interfaces/view_manager/view_manager.mojom:39: SetNodeBounds(uint32 node_id, mojo.Rect bounds) ...
6 years, 7 months ago (2014-05-21 21:16:35 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-21 22:23:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/287053004/100001
6 years, 7 months ago (2014-05-21 22:27:13 UTC) #4
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-21 23:13:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/287053004/120001
6 years, 7 months ago (2014-05-21 23:14:48 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 07:58:18 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 08:45:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/31451)
6 years, 7 months ago (2014-05-22 08:45:22 UTC) #9
Ben Goodger (Google)
6 years, 7 months ago (2014-05-22 17:27:59 UTC) #10
Message was sent while issue was closed. 
Committed patchset #9 manually as r272209 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698