Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 287053003: Let updateLayout do style recalc instead of styleResolverChanged. (Closed)

Created:
6 years, 7 months ago by rune
Modified:
6 years, 7 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Visibility:
Public.

Description

Let updateLayout do style recalc instead of styleResolverChanged. In updateLayoutIgnorePendingStylesheets, updateLayout will make sure updateRenderTreeIfNeeded is called. Hence, we can use deferred style recalc for styleResolverChanged. R=ojan@chromium.org BUG=374162 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174429

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary mime type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
A LayoutTests/http/tests/css/pending-stylesheet-offset-width.css View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/http/tests/css/pending-stylesheet-offset-width.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/css/pending-stylesheet-offset-width-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rune
6 years, 7 months ago (2014-05-20 09:59:35 UTC) #1
ojan
lgtm https://codereview.chromium.org/287053003/diff/1/LayoutTests/http/tests/css/pending-stylesheet-offset-width.html File LayoutTests/http/tests/css/pending-stylesheet-offset-width.html (right): https://codereview.chromium.org/287053003/diff/1/LayoutTests/http/tests/css/pending-stylesheet-offset-width.html#newcode6 LayoutTests/http/tests/css/pending-stylesheet-offset-width.html:6: <link rel="stylesheet" type="text/css" href="/resources/load-and-stall.php?name=pending-stylesheet-offset-width.css&stallAt=0&stallFor=1"> Nit: I usually leave ...
6 years, 7 months ago (2014-05-20 19:22:01 UTC) #2
rune
https://codereview.chromium.org/287053003/diff/1/LayoutTests/http/tests/css/pending-stylesheet-offset-width.html File LayoutTests/http/tests/css/pending-stylesheet-offset-width.html (right): https://codereview.chromium.org/287053003/diff/1/LayoutTests/http/tests/css/pending-stylesheet-offset-width.html#newcode6 LayoutTests/http/tests/css/pending-stylesheet-offset-width.html:6: <link rel="stylesheet" type="text/css" href="/resources/load-and-stall.php?name=pending-stylesheet-offset-width.css&stallAt=0&stallFor=1"> On 2014/05/20 19:22:01, ojan wrote: ...
6 years, 7 months ago (2014-05-20 22:16:04 UTC) #3
rune
The CQ bit was checked by rune@opera.com
6 years, 7 months ago (2014-05-20 22:16:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/287053003/20001
6 years, 7 months ago (2014-05-20 22:16:39 UTC) #5
commit-bot: I haz the power
Change committed as 174429
6 years, 7 months ago (2014-05-20 23:44:06 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 23:44:36 UTC) #7
Message was sent while issue was closed.
Failed to apply patch for
LayoutTests/http/tests/css/pending-stylesheet-offset-width-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  The next patch would create the file
LayoutTests/http/tests/css/pending-stylesheet-offset-width-expected.txt,
  which already exists!  Skipping patch.
  1 out of 1 hunk ignored

Patch:   N  
LayoutTests/http/tests/css/pending-stylesheet-offset-width-expected.txt
Index: LayoutTests/http/tests/css/pending-stylesheet-offset-width-expected.txt
diff --git
a/LayoutTests/http/tests/css/pending-stylesheet-offset-width-expected.txt
b/LayoutTests/http/tests/css/pending-stylesheet-offset-width-expected.txt
new file mode 100644
index
0000000000000000000000000000000000000000..2e9c8e9657562ae94fa143256f915e15c00b99dc
--- /dev/null
+++ b/LayoutTests/http/tests/css/pending-stylesheet-offset-width-expected.txt
@@ -0,0 +1,10 @@
+Check that we use the style present asking for offsetWidth, ignoring pending
stylesheets.
+
+On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".
+
+
+PASS t.offsetWidth is 200
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Powered by Google App Engine
This is Rietveld 408576698