Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2870513002: Make ClientRect an alias of DOMRect

Created:
3 years, 7 months ago by Byoungkwon Ko
Modified:
3 years, 7 months ago
Reviewers:
zino, fserb, foolip
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ClientRect an alias of DOMRect DOMRect was changed sufficiently that ClientRect can be made a simple alias of it. BUG=719246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -153 lines) Patch
M third_party/WebKit/Source/core/core_idl_files.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ClientRect.h View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ClientRect.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ClientRect.idl View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Byoungkwon Ko
@Jinho. According to WebKitCSSMatrix method, I made ClientRect an alias of DOMRect. But ClientRect is ...
3 years, 7 months ago (2017-05-07 12:16:39 UTC) #2
Byoungkwon Ko
@PTAL
3 years, 7 months ago (2017-05-09 15:38:10 UTC) #5
fserb
3 years, 7 months ago (2017-05-10 17:44:40 UTC) #7 
lgtm

Powered by Google App Engine
This is Rietveld 408576698