Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2870363003: Allowing `e` of any type in `void f(...) => e` in the analyzer. (Closed)

Created:
3 years, 7 months ago by eernst
Modified:
3 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allowing `e` of any type in `void f(...) => e` in the analyzer. Re-land, now including adjustment of two tests in pkg/analyzer/test. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/6cb0966401f2a53196358945c0f78a32c575a8dc

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +8 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/void_arrow_return_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/language/void_block_return_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
This is a re-landing of CL 2870063002, which caused 3 tests in pkg/analyzer/test to fail. ...
3 years, 7 months ago (2017-05-10 12:13:55 UTC) #2
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-05-10 15:44:17 UTC) #3
eernst
3 years, 7 months ago (2017-05-11 08:10:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6cb0966401f2a53196358945c0f78a32c575a8dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698