chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java - Issue 2870313002: In-product-help: Accessibility text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Issue 2870313002: In-product-help: Accessibility text (Closed)

Patch Set: After Victor's feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

index c63bd7d7f7aa65ebad23244c42ea2247bd614732..b58f3bf542402ff28c821820a106578e612adf01 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

@@ -528,7 +528,8 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe

if (!tracker.shouldTriggerHelpUI(FeatureConstants.DOWNLOAD_PAGE_FEATURE)) return;

mTextBubble = new ViewAnchoredTextBubble(mToolbar.getContext(), getMenuAnchor(),

- R.string.iph_download_page_for_offline_usage_text);

+ R.string.iph_download_page_for_offline_usage_text,

+ R.string.iph_download_page_for_offline_usage_accessibility_text);

mTextBubble.setDismissOnTouchInteraction(true);

mTextBubble.addOnDismissListener(new OnDismissListener() {

@Override