chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2870313002: In-product-help: Accessibility text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2870313002: In-product-help: Accessibility text (Closed)

Patch Set: After Victor's feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 771ca11fd63452ba1506e495019e7ad30a36e239..0fb8840778aeebb92076db648db7f6e60bccd52b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -715,8 +715,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

Profile.getLastUsedProfile());

if (!tracker.shouldTriggerHelpUI(FeatureConstants.DOWNLOAD_HOME_FEATURE)) return;

- ViewAnchoredTextBubble textBubble = new ViewAnchoredTextBubble(

- this, getToolbarManager().getMenuAnchor(), R.string.iph_download_home_text);

+ ViewAnchoredTextBubble textBubble = new ViewAnchoredTextBubble(this,

+ getToolbarManager().getMenuAnchor(), R.string.iph_download_home_text,

+ R.string.iph_download_home_accessibility_text);

textBubble.setDismissOnTouchInteraction(true);

textBubble.addOnDismissListener(new OnDismissListener() {

@Override