Add support for redirecting constructors and instance field initialization

Add support for redirecting constructors and instance field initialization

Instance fields only in immediately enclosing class are initialized.

BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/62c0be200e7e84f14debef22a5ef014f51a7fa8d

[zhivkag, 2017-05-10 12:26:39]

zhivkag@google.com changed reviewers:
+ dmitryas@google.com, kmillikin@google.com

[zhivkag, 2017-05-10 12:26:39]

Hi, 

This change adds support for invocation of constructors for the following steps
of the initialization of a new instance: 
- New instance allocation
- Redirecting constructor invocation
- Initialization of instance fields in the immediately enclosing class. 

It modifies the "evalArgs" to "evalList", it now evaluates list of
InterpreterExpressions and we can use it to evaluate the list of argument, local
initializers and field initializer expressions.

It introduces 3 new Application continuations for: 
- Applying the evaluated arguments for Constructor invocation 
- Applying the evaluated expressions for instance field initialization, i.e.
setting values of fields.
- Applying the evaluated expressions for local initializers in front of a
redirecting initializer, i.e. adding the variables with their values to the
environment. 

Additional support for execution of initializer list and super invocation will
follow in other CLs.

Thanks, 
Zhivka

[Dmitry Stefantsov, 2017-05-11 07:44:42]

It LGTM! I only have a couple of suggestions about naming things.

https://codereview.chromium.org/2870263003/diff/20001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2870263003/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:89: Configuration
evalList(List<InterpreterExpression> args, Environment env,
Now that we renamed "evalArgs" to "evalList", should we also rename "args"
parameter to "list"?

https://codereview.chromium.org/2870263003/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:357: final List<InterpreterValue>
argumentValues;
Same as above. Shouldn't it be "listItemValues" or "itemValues" now?

https://codereview.chromium.org/2870263003/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:397: InterpreterValue
withValue(Value v);
Previously, when we defined "x.withSomething" methods, they always returned a
value of the same type as that of "x". It meant that we want almost the same
"x", but with this new "something".

Here "withValue" is called on an "InterpreterExpression", but returns an
"InterpreterValue"; it breaks the convention mentioned above.

I suggest renaming "withValue" to something like "evaluateTo" or "assign".

[zhivkag, 2017-05-11 07:55:33]

Thanks!

https://codereview.chromium.org/2870263003/diff/20001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2870263003/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:89: Configuration
evalList(List<InterpreterExpression> args, Environment env,
On 2017/05/11 07:44:42, Dmitry Stefantsov wrote:
> Now that we renamed "evalArgs" to "evalList", should we also rename "args"
> parameter to "list"?

Done.

https://codereview.chromium.org/2870263003/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:357: final List<InterpreterValue>
argumentValues;
On 2017/05/11 07:44:42, Dmitry Stefantsov wrote:
> Same as above. Shouldn't it be "listItemValues" or "itemValues" now?

Done.

https://codereview.chromium.org/2870263003/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:397: InterpreterValue
withValue(Value v);
On 2017/05/11 07:44:42, Dmitry Stefantsov wrote:
> Previously, when we defined "x.withSomething" methods, they always returned a
> value of the same type as that of "x". It meant that we want almost the same
> "x", but with this new "something".
> 
> Here "withValue" is called on an "InterpreterExpression", but returns an
> "InterpreterValue"; it breaks the convention mentioned above.
> 
> I suggest renaming "withValue" to something like "evaluateTo" or "assign".

Done.

[zhivkag, 2017-05-11 09:45:42]

Description was changed from

==========
Add support for redirecting constructors and instance field initialization

Instance fields only in immediately enclosing class are initialized.

BUG=
==========

to

==========
Add support for redirecting constructors and instance field initialization

Instance fields only in immediately enclosing class are initialized.

BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/62c0be200e7e84f14debef22a5ef014f51a7fa8d
==========

[zhivkag, 2017-05-11 09:45:43]

Committed patchset #3 (id:40001) manually as
62c0be200e7e84f14debef22a5ef014f51a7fa8d (presubmit successful).