Make Hands-Off Zero-Touch Enrollment compatibile with tests

chrome/browser/chromeos/login/startup_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/startup_utils.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
@@ skipping 21 matching lines @@
   prefs->CommitPendingWrite();
 }
 
 // Saves integer "Local State" preference and forces its persistence to disk.
 void SaveIntegerPreferenceForced(const char* pref_name, int value) {
   PrefService* prefs = g_browser_process->local_state();
   prefs->SetInteger(pref_name, value);
   prefs->CommitPendingWrite();
 }
 
+// Saves 64 bit signed integer "Local State" preference and forces its
+// persistence to disk.
+void SaveInt64PreferenceForced(const char* pref_name, int64_t value) {
+  PrefService* prefs = g_browser_process->local_state();
+  prefs->SetInt64(pref_name, value);
+  prefs->CommitPendingWrite();
+}
+
 // Saves string "Local State" preference and forces its persistence to disk.
 void SaveStringPreferenceForced(const char* pref_name,
                                 const std::string& value) {
   PrefService* prefs = g_browser_process->local_state();
   prefs->SetString(pref_name, value);
   prefs->CommitPendingWrite();
 }
 
 // Returns the path to flag file indicating that both parts of OOBE were
 // completed.
@@ skipping 30 matching lines @@
 
 // static
 void StartupUtils::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterBooleanPref(prefs::kOobeComplete, false);
   registry->RegisterStringPref(prefs::kOobeScreenPending, "");
   registry->RegisterBooleanPref(prefs::kOobeMdMode, false);
   registry->RegisterIntegerPref(prefs::kDeviceRegistered, -1);
   registry->RegisterBooleanPref(prefs::kEnrollmentRecoveryRequired, false);
   registry->RegisterStringPref(prefs::kInitialLocale, "en-US");
   registry->RegisterBooleanPref(prefs::kIsBootstrappingSlave, false);
   registry->RegisterBooleanPref(prefs::kOobeControllerDetected, false);

[xiyuan, 2017/05/09 22:03:52]

You need to register kTimeOfLastUpdateCheckWithoutUpdate here.

[kumarniranjan, 2017/05/09 22:49:47]

Done.

 }
 
 // static
 bool StartupUtils::IsEulaAccepted() {
   return g_browser_process->local_state()->GetBoolean(prefs::kEulaAccepted);
 }
 
 // static
 bool StartupUtils::IsOobeCompleted() {
   return g_browser_process->local_state()->GetBoolean(prefs::kOobeComplete);
@@ skipping 88 matching lines @@
 }
 
 // static
 void StartupUtils::SetInitialLocale(const std::string& locale) {
   if (l10n_util::IsValidLocaleSyntax(locale))
     SaveStringPreferenceForced(prefs::kInitialLocale, locale);
   else
     NOTREACHED();
 }
 
+// static
+void StartupUtils::SaveTimeOfLastUpdateCheckWithoutUpdate(base::Time time) {
+  SaveInt64PreferenceForced(prefs::kTimeOfLastUpdateCheckWithoutUpdate,

[xiyuan, 2017/05/09 22:03:52]

Where is kTimeOfLastUpdateCheckWithoutUpdate defined?

[kumarniranjan, 2017/05/09 22:49:47]

Done.

+                            time->ToInternalvalue());
+}
+
+// static
+base::Time StartupUtils::GetTimeOfLastUpdateCheckWithoutUpdate() {
+  return base::Time::FromInternalValue(
+      g_browser_process->local_state()->GetInt64(
+          prefs::kTimeOfLastUpdateCheckWithoutUpdate));
+}
+
 }  // namespace chromeos