Chromium Code Reviews| Index: tools/metrics/histograms/enums.xml |
| diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml |
| index 5e3d0076bcd9555131bd707d3b29144c987a8590..92c367b1a5997734df2085b1669fc0688b5bf82a 100644 |
| --- a/tools/metrics/histograms/enums.xml |
| +++ b/tools/metrics/histograms/enums.xml |
| @@ -1838,79 +1838,185 @@ uploading your change for review. These are checked by presubmit scripts. |
| </enum> |
| <enum name="AutofillTypeQuality" type="int"> |
| - <int value="0" label="Unknown"/> |
| - <int value="1" label="Match"/> |
| - <int value="2" label="Mismatch"/> |
| - <int value="3" label="Match - Empty Data"/> |
| - <int value="4" label="Match - Unknown Data"/> |
| - <int value="5" label="Mismatch - Empty Data"/> |
| - <int value="6" label="Mismatch - Unknown Data"/> |
| + <int value="0" label="False Negative (Unknown)"/> |
| + <int value="1" label="True Positive"/> |
| + <int value="2" label="False Negative (Mismatch)"/> |
| + <int value="3" label="True Negative (Empty"/> |
| + <int value="4" label="True Negative (Unknown)"/> |
| + <int value="5" label="False Positive (Empty)"/> |
| + <int value="6" label="False Positive (Unknown)"/> |
| + <int value="7" label="False Positive (Mismatch)"/> |
| </enum> |
| <enum name="AutofillTypeQualityByFieldType" type="int"> |
| - <int value="0" label="Ambiguous, Unknown"/> |
| - <int value="1" label="Ambiguous, Match"/> |
| - <int value="2" label="Ambiguous, Mismatch"/> |
| - <int value="3" label="Name, Unknown"/> |
| - <int value="4" label="Name, Match"/> |
| - <int value="5" label="Name, Mismatch"/> |
| - <int value="6" label="Company, Unknown"/> |
| - <int value="7" label="Company, Match"/> |
| - <int value="8" label="Company, Mismatch"/> |
| - <int value="9" label="Addr. line 1, Unknown"/> |
| - <int value="10" label="Addr. line 1, Match"/> |
| - <int value="11" label="Addr. line 1, Mismatch"/> |
| - <int value="12" label="Addr. line 2, Unknown"/> |
| - <int value="13" label="Addr. line 2, Match"/> |
| - <int value="14" label="Addr. line 2, Mismatch"/> |
| - <int value="15" label="City, Unknown"/> |
| - <int value="16" label="City, Match"/> |
| - <int value="17" label="City, Mismatch"/> |
| - <int value="18" label="State, Unknown"/> |
| - <int value="19" label="State, Match"/> |
| - <int value="20" label="State, Mismatch"/> |
| - <int value="21" label="ZIP code, Unknown"/> |
| - <int value="22" label="ZIP code, Match"/> |
| - <int value="23" label="ZIP code, Mismatch"/> |
| - <int value="24" label="Country, Unknown"/> |
| - <int value="25" label="Country, Match"/> |
| - <int value="26" label="Country, Mismatch"/> |
| - <int value="27" label="Phone, Unknown"/> |
| - <int value="28" label="Phone, Match"/> |
| - <int value="29" label="Phone, Mismatch"/> |
| - <int value="30" label="Fax, Unknown"/> |
| - <int value="31" label="Fax, Match"/> |
| - <int value="32" label="Fax, Mismatch"/> |
| - <int value="33" label="Email, Unknown"/> |
| - <int value="34" label="Email, Match"/> |
| - <int value="35" label="Email, Mismatch"/> |
| - <int value="36" label="Credit card: name, Unknown"/> |
| - <int value="37" label="Credit card: name, Match"/> |
| - <int value="38" label="Credit card: name, Mismatch"/> |
| - <int value="39" label="Credit card: number, Unknown"/> |
| - <int value="40" label="Credit card: number, Match"/> |
| - <int value="41" label="Credit card: number, Mismatch"/> |
| - <int value="42" label="Credit card: date, Unknown"/> |
| - <int value="43" label="Credit card: date, Match"/> |
| - <int value="44" label="Credit card: date, Mismatch"/> |
| - <int value="45" label="Credit card: type, Unknown"/> |
| - <int value="46" label="Credit card: type, Match"/> |
| - <int value="47" label="Credit card: type, Mismatch"/> |
| - <int value="48" label="Password, Unknown"/> |
| - <int value="49" label="Password, Match"/> |
| - <int value="50" label="Password, Mismatch"/> |
| - <int value="51" label="Addr. line 3, Unknown"/> |
| - <int value="52" label="Addr. line 3, Match"/> |
| - <int value="53" label="Addr. line 3, Mismatch"/> |
| - <int value="54" label="Username, Unknown"/> |
| - <int value="55" label="Username, Match"/> |
| - <int value="56" label="Username, Mismatch"/> |
| - <int value="57" label="Street Address, Unknown"/> |
| - <int value="58" label="Street Address, Match"/> |
| - <int value="59" label="Street Address, Mismatch"/> |
| - <int value="60" label="Credit Card Verification, Unknown"/> |
| - <int value="61" label="Credit Card Verification, Match"/> |
| - <int value="62" label="Credit Card Verification, Mismatch"/> |
| + <int value="0" label="Ambiguous: False Negative (Unknown)"/> |
|
sebsg
2017/05/24 14:09:02
The issue with this is that the previous data coll
Roger McFarlane (Chromium)
2017/05/24 15:36:12
Indeed. I forgot to discuss this in the review req
|
| + <int value="1" label="Ambiguous: True Positive"/> |
| + <int value="2" label="Ambiguous: False Negative (Mismatch)"/> |
| + <int value="3" label="Ambiguous: True Negative (Empty)"/> |
| + <int value="4" label="Ambiguous: True Negative (Unknown)"/> |
| + <int value="5" label="Ambiguous: False Positive (Empty)"/> |
| + <int value="6" label="Ambiguous: False Positive (Unknown)"/> |
| + <int value="7" label="Ambiguous: False Positive (Mismatch)"/> |
| + <int value="8" label="Name: False Negative (Unknown)"/> |
| + <int value="9" label="Name: True Positive"/> |
| + <int value="10" label="Name: False Negative (Mismatch)"/> |
| + <int value="11" label="Name: True Negative (Empty)"/> |
| + <int value="12" label="Name: True Negative (Unknown)"/> |
| + <int value="13" label="Name: False Positive (Empty)"/> |
| + <int value="14" label="Name: False Positive (Unknown)"/> |
| + <int value="15" label="Name: False Positive (Mismatch)"/> |
| + <int value="16" label="Company: False Negative (Unknown)"/> |
| + <int value="17" label="Company: True Positive"/> |
| + <int value="18" label="Company: False Negative (Mismatch)"/> |
| + <int value="19" label="Company: True Negative (Empty)"/> |
| + <int value="20" label="Company: True Negative (Unknown)"/> |
| + <int value="21" label="Company: False Positive (Empty)"/> |
| + <int value="22" label="Company: False Positive (Unknown)"/> |
| + <int value="23" label="Company: False Positive (Mismatch)"/> |
| + <int value="24" label="Address Line 1: False Negative (Unknown)"/> |
| + <int value="25" label="Address Line 1: True Positive"/> |
| + <int value="26" label="Address Line 1: False Negative (Mismatch)"/> |
| + <int value="27" label="Address Line 1: True Negative (Empty)"/> |
| + <int value="28" label="Address Line 1: True Negative (Unknown)"/> |
| + <int value="29" label="Address Line 1: False Positive (Empty)"/> |
| + <int value="30" label="Address Line 1: False Positive (Unknown)"/> |
| + <int value="31" label="Address Line 1: False Positive (Mismatch)"/> |
| + <int value="32" label="Address Line 2: False Negative (Unknown)"/> |
| + <int value="33" label="Address Line 2: True Positive"/> |
| + <int value="34" label="Address Line 2: False Negative (Mismatch)"/> |
| + <int value="35" label="Address Line 2: True Negative (Empty)"/> |
| + <int value="36" label="Address Line 2: True Negative (Unknown)"/> |
| + <int value="37" label="Address Line 2: False Positive (Empty)"/> |
| + <int value="38" label="Address Line 2: False Positive (Unknown)"/> |
| + <int value="39" label="Address Line 2: False Positive (Mismatch)"/> |
| + <int value="40" label="City: False Negative (Unknown)"/> |
| + <int value="41" label="City: True Positive"/> |
| + <int value="42" label="City: False Negative (Mismatch)"/> |
| + <int value="43" label="City: True Negative (Empty)"/> |
| + <int value="44" label="City: True Negative (Unknown)"/> |
| + <int value="45" label="City: False Positive (Empty)"/> |
| + <int value="46" label="City: False Positive (Unknown)"/> |
| + <int value="47" label="City: False Positive (Mismatch)"/> |
| + <int value="48" label="State: False Negative (Unknown)"/> |
| + <int value="49" label="State: True Positive"/> |
| + <int value="50" label="State: False Negative (Mismatch)"/> |
| + <int value="51" label="State: True Negative (Empty)"/> |
| + <int value="52" label="State: True Negative (Unknown)"/> |
| + <int value="53" label="State: False Positive (Empty)"/> |
| + <int value="54" label="State: False Positive (Unknown)"/> |
| + <int value="55" label="State: False Positive (Mismatch)"/> |
| + <int value="56" label="ZIP: False Negative (Unknown)"/> |
| + <int value="57" label="ZIP: True Positive"/> |
| + <int value="58" label="ZIP: False Negative (Mismatch)"/> |
| + <int value="59" label="ZIP: True Negative (Empty)"/> |
| + <int value="60" label="ZIP: True Negative (Unknown)"/> |
| + <int value="61" label="ZIP: False Positive (Empty)"/> |
| + <int value="62" label="ZIP: False Positive (Unknown)"/> |
| + <int value="63" label="ZIP: False Positive (Mismatch)"/> |
| + <int value="64" label="Country: False Negative (Unknown)"/> |
| + <int value="65" label="Country: True Positive"/> |
| + <int value="66" label="Country: False Negative (Mismatch)"/> |
| + <int value="67" label="Country: True Negative (Empty)"/> |
| + <int value="68" label="Country: True Negative (Unknown)"/> |
| + <int value="69" label="Country: False Positive (Empty)"/> |
| + <int value="70" label="Country: False Positive (Unknown)"/> |
| + <int value="71" label="Country: False Positive (Mismatch)"/> |
| + <int value="72" label="Phone: False Negative (Unknown)"/> |
| + <int value="73" label="Phone: True Positive"/> |
| + <int value="74" label="Phone: False Negative (Mismatch)"/> |
| + <int value="75" label="Phone: True Negative (Empty)"/> |
| + <int value="76" label="Phone: True Negative (Unknown)"/> |
| + <int value="77" label="Phone: False Positive (Empty)"/> |
| + <int value="78" label="Phone: False Positive (Unknown)"/> |
| + <int value="79" label="Phone: False Positive (Mismatch)"/> |
| + <int value="80" label="Fax: False Negative (Unknown)"/> |
| + <int value="81" label="Fax: True Positive"/> |
| + <int value="82" label="Fax: False Negative (Mismatch)"/> |
| + <int value="83" label="Fax: True Negative (Empty)"/> |
| + <int value="84" label="Fax: True Negative (Unknown)"/> |
| + <int value="85" label="Fax: False Positive (Empty)"/> |
| + <int value="86" label="Fax: False Positive (Unknown)"/> |
| + <int value="87" label="Fax: False Positive (Mismatch)"/> |
| + <int value="88" label="Email: False Negative (Unknown)"/> |
| + <int value="89" label="Email: True Positive"/> |
| + <int value="90" label="Email: False Negative (Mismatch)"/> |
| + <int value="91" label="Email: True Negative (Empty)"/> |
| + <int value="92" label="Email: True Negative (Unknown)"/> |
| + <int value="93" label="Email: False Positive (Empty)"/> |
| + <int value="94" label="Email: False Positive (Unknown)"/> |
| + <int value="95" label="Email: False Positive (Mismatch)"/> |
| + <int value="96" label="CC Name: False Negative (Unknown)"/> |
| + <int value="97" label="CC Name: True Positive"/> |
| + <int value="98" label="CC Name: False Negative (Mismatch)"/> |
| + <int value="99" label="CC Name: True Negative (Empty)"/> |
| + <int value="100" label="CC Name: True Negative (Unknown)"/> |
| + <int value="101" label="CC Name: False Positive (Empty)"/> |
| + <int value="102" label="CC Name: False Positive (Unknown)"/> |
| + <int value="103" label="CC Name: False Positive (Mismatch)"/> |
| + <int value="104" label="CC Number: False Negative (Unknown)"/> |
| + <int value="105" label="CC Number: True Positive"/> |
| + <int value="106" label="CC Number: False Negative (Mismatch)"/> |
| + <int value="107" label="CC Number: True Negative (Empty)"/> |
| + <int value="108" label="CC Number: True Negative (Unknown)"/> |
| + <int value="109" label="CC Number: False Positive (Empty)"/> |
| + <int value="110" label="CC Number: False Positive (Unknown)"/> |
| + <int value="111" label="CC Number: False Positive (Mismatch)"/> |
| + <int value="112" label="CC Expiry: False Negative (Unknown)"/> |
| + <int value="113" label="CC Expiry: True Positive"/> |
| + <int value="114" label="CC Expiry: False Negative (Mismatch)"/> |
| + <int value="115" label="CC Expiry: True Negative (Empty)"/> |
| + <int value="116" label="CC Expiry: True Negative (Unknown)"/> |
| + <int value="117" label="CC Expiry: False Positive (Empty)"/> |
| + <int value="118" label="CC Expiry: False Positive (Unknown)"/> |
| + <int value="119" label="CC Expiry: False Positive (Mismatch)"/> |
| + <int value="120" label="CC Type: False Negative (Unknown)"/> |
| + <int value="121" label="CC Type: True Positive"/> |
| + <int value="122" label="CC Type: False Negative (Mismatch)"/> |
| + <int value="123" label="CC Type: True Negative (Empty)"/> |
| + <int value="124" label="CC Type: True Negative (Unknown)"/> |
| + <int value="125" label="CC Type: False Positive (Empty)"/> |
| + <int value="126" label="CC Type: False Positive (Unknown)"/> |
| + <int value="127" label="CC Type: False Positive (Mismatch)"/> |
| + <int value="128" label="Password: False Negative (Unknown)"/> |
| + <int value="129" label="Password: True Positive"/> |
| + <int value="130" label="Password: False Negative (Mismatch)"/> |
| + <int value="131" label="Password: True Negative (Empty)"/> |
| + <int value="132" label="Password: True Negative (Unknown)"/> |
| + <int value="133" label="Password: False Positive (Empty)"/> |
| + <int value="134" label="Password: False Positive (Unknown)"/> |
| + <int value="135" label="Password: False Positive (Mismatch)"/> |
| + <int value="136" label="Address Line 3: False Negative (Unknown)"/> |
| + <int value="137" label="Address Line 3: True Positive"/> |
| + <int value="138" label="Address Line 3: False Negative (Mismatch)"/> |
| + <int value="139" label="Address Line 3: True Negative (Empty)"/> |
| + <int value="140" label="Address Line 3: True Negative (Unknown)"/> |
| + <int value="141" label="Address Line 3: False Positive (Empty)"/> |
| + <int value="142" label="Address Line 3: False Positive (Unknown)"/> |
| + <int value="143" label="Address Line 3: False Positive (Mismatch)"/> |
| + <int value="144" label="Username: False Negative (Unknown)"/> |
| + <int value="145" label="Username: True Positive"/> |
| + <int value="146" label="Username: False Negative (Mismatch)"/> |
| + <int value="147" label="Username: True Negative (Empty)"/> |
| + <int value="148" label="Username: True Negative (Unknown)"/> |
| + <int value="149" label="Username: False Positive (Empty)"/> |
| + <int value="150" label="Username: False Positive (Unknown)"/> |
| + <int value="151" label="Username: False Positive (Mismatch)"/> |
| + <int value="152" label="Street Address: False Negative (Unknown)"/> |
| + <int value="153" label="Street Address: True Positive"/> |
| + <int value="154" label="Street Address: False Negative (Mismatch)"/> |
| + <int value="155" label="Street Address: True Negative (Empty)"/> |
| + <int value="156" label="Street Address: True Negative (Unknown)"/> |
| + <int value="157" label="Street Address: False Positive (Empty)"/> |
| + <int value="158" label="Street Address: False Positive (Unknown)"/> |
| + <int value="159" label="Street Address: False Positive (Mismatch)"/> |
| + <int value="160" label="CVC: False Negative (Unknown)"/> |
| + <int value="161" label="CVC: True Positive"/> |
| + <int value="162" label="CVC: False Negative (Mismatch)"/> |
| + <int value="163" label="CVC: True Negative (Empty)"/> |
| + <int value="164" label="CVC: True Negative (Unknown)"/> |
| + <int value="165" label="CVC: False Positive (Empty)"/> |
| + <int value="166" label="CVC: False Positive (Unknown)"/> |
| + <int value="167" label="CVC: False Positive (Mismatch)"/> |
| </enum> |
| <enum name="AutofillUnmaskPromptEvent" type="int"> |